#37 Add ability to create users with needs rotation and rotate their key #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeet70
approved these changes
Feb 24, 2020
src/Constants.ts
Outdated
| @@ -39,6 +39,9 @@ export const ErrorCodes = { | |||
| USER_DEVICE_KEY_GENERATION_FAILURE: 207, | |||
| USER_DEVICE_LIST_REQUEST_FAILURE: 208, | |||
| USER_DEVICE_DELETE_REQUEST_FAILURE: 209, | |||
| USER_UPDATE_KEY_REQUEST_FAILURE: 210, | |||
| USER_PRIVATE_KEY_ROTATION_FAILURE: 211, | |||
| USER_CURRENT_GET_REQUEST_FAILURE: 212, | |||
There was a problem hiding this comment.
Suggested change
| USER_CURRENT_GET_REQUEST_FAILURE: 212, | |
| USER_GET_CURRENT_REQUEST_FAILURE: 212, |
There was a problem hiding this comment.
Actually just removed this for now as we don't need it.
| /** | ||
| * Augments the provided user private key and return both the augmented private key and the augmentation factor. | ||
| */ | ||
| const rotateUsersPrivateKey = (userPrivateKey: Buffer): Future<Error, {newPrivateKey: Buffer; augmentationFactor: Buffer}> => { |
There was a problem hiding this comment.
Should we export this too so they could use it without retry if desired?
There was a problem hiding this comment.
I can't imagine a situation where you would never want to retry.
There was a problem hiding this comment.
Ya, this method isn't exposed out to callers, it's all wrapped behind the key rotation call. Given the low likelihood of it actually failing I don't think it matters.
coltfred
approved these changes
Feb 24, 2020
| /** | ||
| * Augments the provided user private key and return both the augmented private key and the augmentation factor. | ||
| */ | ||
| const rotateUsersPrivateKey = (userPrivateKey: Buffer): Future<Error, {newPrivateKey: Buffer; augmentationFactor: Buffer}> => { |
There was a problem hiding this comment.
I can't imagine a situation where you would never want to retry.
ernieturner
pushed a commit
that referenced
this pull request
Mar 4, 2020
* #37 Add ability to create users with needs rotation and rotate th… (#39) * #37 Add ability to create users with needs rotation and rotate their key * Remove unused error code * #37 Add key rotation for groups and change init response to retur… (#40) * #37 Add key rotation for groups and change init response to return info about current user for rotation purposes * Expand details in comment * Add missing test, bump up test coverage leniency for Recrypt tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.