#37 Add key rotation for groups and change init response to return in… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo about current user for rotation purposes
skeet70
approved these changes
Mar 4, 2020
clintfred
approved these changes
Mar 4, 2020
src/sdk/GroupSDK.ts
Outdated
| @@ -42,6 +42,17 @@ export function update(groupID: string, options: GroupUpdateOptions) { | |||
| throw new Error("Group update must provide a new name which is either a non-zero length string or null."); | |||
| } | |||
|
|
|||
| /** | |||
| * Rotate a groups private key. This allows for changing the private key of a group without having to re-encrypt any of the documents | |||
| * encrypted to the group. This operation will re-add every existing admin of the group so depending on the number of admins this | |||
There was a problem hiding this comment.
Might be worth calling out that the group's public key does not change even though that has the same meaning as "without having to re-encrypt any..."
ernieturner
pushed a commit
that referenced
this pull request
Mar 4, 2020
* #37 Add ability to create users with needs rotation and rotate th… (#39) * #37 Add ability to create users with needs rotation and rotate their key * Remove unused error code * #37 Add key rotation for groups and change init response to retur… (#40) * #37 Add key rotation for groups and change init response to return info about current user for rotation purposes * Expand details in comment * Add missing test, bump up test coverage leniency for Recrypt tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fo about current user for rotation purposes