Fixes for several tests in test_bool #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slozier
reviewed
Mar 2, 2017
| Ast.IfThen(Ast.LessThan(res, Ast.Constant(0)), | ||
| Ast.Throw( | ||
| Ast.Call( | ||
| typeof(PythonOps).GetMethod("ValueError"), |
There was a problem hiding this comment.
I wonder if we should really be throwing errors like that in the IL.
There was a problem hiding this comment.
We have to the way this is implemented. It doesn't use the normal len call, so it has to be thrown in here.
| @@ -839,7 +845,7 @@ public static partial class PythonOps { | |||
| } | |||
|
|
|||
| if (res < 0) { | |||
| throw PythonOps.ValueError("__len__ should return >= 0, got {0}", res); | |||
| throw PythonOps.ValueError("__len__ should return >= 0"); | |||
There was a problem hiding this comment.
Missing the parentheses __len__()
| @@ -470,6 +470,9 @@ public static partial class PythonOps { | |||
| } | |||
|
|
|||
| public static object Is(object x, object y) { | |||
| if(x is bool && y is bool) { | |||
There was a problem hiding this comment.
What about reusing IronLanguages/main#1332 instead of having something different? Unless this fixes something else...
There was a problem hiding this comment.
Yeah, that's a way better idea. I'll revert what I have for that and merge.
slozier
approved these changes
Mar 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.