This repository has been archived by the owner on Sep 14, 2018. It is now read-only.
special case identiy checks for booleans #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks good. Did you run the whole test suite just to make sure it doesn't cause issues elsewhere? |
|
No. At the moment, the test suite hangs at various places with 100% CPU and issues Debugger.Launch() statements and other message boxes. |
|
I checked |
slide
added a commit
to IronLanguages/ironpython3
that referenced
this pull request
Mar 2, 2017
* Fixes for several tests in test_bool * Merge in from IronLanguages/main#1332
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would this be an option to fix #1299 and similar issues?
The runtime impact of the code to non-bool objects is one additional cast per identity check.