Update Array#inspect to taint result strings correctly as per rubyspec

IronLanguages · Feb 1, 2012 · c89e236 · c89e236
1 parent ae966af
commit c89e236
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/Languages/Ruby/Libraries/Extensions/IListOps.cs b/Languages/Ruby/Libraries/Extensions/IListOps.cs
@@ -1606,6 +1606,10 @@ private static void JoinRecursive(JoinConversionStorage/*!*/ conversions, IList/
                     return MutableString.CreateAscii("[...]");
                 }
                 MutableString str = MutableString.CreateMutable(RubyEncoding.Binary);
+                if (self.Count > 0) { // tainted empty arrays don't taint the inspect string if the array is empty
+                    str.TaintBy(self, context);
+                }
+
                 str.Append('[');
                 bool first = true;
                 foreach (object obj in self) {
@@ -1614,7 +1618,10 @@ private static void JoinRecursive(JoinConversionStorage/*!*/ conversions, IList/
                     } else {
                         str.Append(", ");
                     }
-                    str.Append(context.Inspect(obj));
+
+                    var objInspected = context.Inspect(obj);
+                    str.Append(objInspected);
+                    str.TaintBy(objInspected);
                 }
                 str.Append(']');
                 return str;