Skip to content

Commit

Permalink
Add optional config file in /usr/lib
Browse files Browse the repository at this point in the history 
immutable distributions have a need for distribution specific configs in
a read only space, and so modify the service file to optionally read a
config file from /usr/lib/irqbalance/default.env

Addresses #118

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
  • Loading branch information
@nhorman
nhorman committed Sep 17, 2019
1 parent b3ae88a commit 724243f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion misc/irqbalance.service
View file
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ Documentation=https://github.com/Irqbalance/irqbalance
ConditionVirtualization=!container ConditionVirtualization=!container


[Service] [Service]
EnvironmentFile=/path/to/irqbalance.env Environmentfile=-/usr/lib/irqbalance/defaults.env

This comment has been minimized.

Sign in to view

Copy link
@lucab

lucab Sep 17, 2019

Sorry, this was just my silly-named example.
It looks like the actual file in this repo is called irqbalance.env, do you maybe want to match the two names (in either direction)?
EnvironmentFile=-/path/to/irqbalance.env
ExecStart=/usr/sbin/irqbalance --foreground $IRQBALANCE_ARGS ExecStart=/usr/sbin/irqbalance --foreground $IRQBALANCE_ARGS
CapabilityBoundingSet= CapabilityBoundingSet=
NoNewPrivileges=yes NoNewPrivileges=yes
Expand Down

1 comment on commit 724243f

@nhorman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think thats needed, the read-only path is already in a directory named irqbalance, so I don't see a reason to duplicate that

Please sign in to comment.