configure.ac: use pkg-config to find numa #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't bother with the fallback mechanism. If libnuma has a pkg-config file, let's just use it. Also there is no reason. To do the AC_SUBST calls, PKG_CHECK_MODULES will handle that (see the glib2 use) |
|
I'll remove the |
Use pkg-config to find numa and fallback to current mechanism. Thanks to pkg-config, numa dependencies such as -latomic will be retrieved. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Thank you! 2 years is my general rule for not worrying about a fallback mechanism. If a system can't update their libraries for two years, they can figure out compatibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pkg-config to find numa and fallback to current mechanism. Thanks to pkg-config, numa dependencies such as
-latomicwill be retrieved.Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com