meson: move build files to repository root #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the README and github ticket discussion, the purpose of having it in contrib/ is to gauge community interest. This interest has now been expressed by several parties, so that interest is certainly there. Let's move it to a more discoverable location. This has two benefits: - usability. If various parties intend to use it, then it is easier to do so from the repository root rather than cd'ing into a subdir. - discoverability. At least Gentoo didn't initially realize it existed, since it wasn't in the repository root, but switched after realizing. It seems reasonable that other redistributors, too, would be interested in evaluating its use but hadn't previously noticed the option. Addresses: #211 (comment) Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
This was not done in commit f8b8cdd. Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
It is unnecessary to set the install directory for manpages, since meson infers this from the file extension and installs *.1 manpages to mandir in the man1 section for you. It is also unnecessary to tag them as "en" because that is the default... it is likewise unnecessary to tag them with manual file permissions since the default 644 permission is also the overridden one. Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Indicate the minimum required version of meson. Version 0.47 (released March 2020) is needed regardless, since it provides the cross-platform curses dependency wrapper. This just lets meson know that, so it can: - warn you if you use features from newer versions you didn't intend to use, which is a sign to either require a higher minimum or avoid the new feature for maximal compatibility - error out if you have an older version of meson too old to build correctly with Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the README and github ticket discussion, the purpose of having it in contrib/ is to gauge community interest. This interest has now been expressed by several parties, so that interest is certainly there.
Let's move it to a more discoverable location. This has two benefits:
usability. If various parties intend to use it, then it is easier to do so from the repository root rather than cd'ing into a subdir.
discoverability. At least Gentoo didn't initially realize it existed, since it wasn't in the repository root, but switched after realizing. It seems reasonable that other redistributors, too, would be interested in evaluating its use but hadn't previously noticed the option.
Addresses: #211 (comment)