Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix about page issues and app version to remove revision #196

Merged
merged 2 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions appLauncher.sln
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ VisualStudioVersion = 17.6.33815.320
MinimumVisualStudioVersion = 10.0.40219.1
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "appLauncher", "appLauncher\appLauncher.csproj", "{825249DF-2022-4222-96A1-69A32AA4E16C}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "GoogleAnalyticsv4SDK", "..\GoogleAnalyticsv4SDKFor.Net\GoogleAnalyticsv4SDK\GoogleAnalyticsv4SDK.csproj", "{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -51,26 +49,6 @@ Global
{825249DF-2022-4222-96A1-69A32AA4E16C}.Release|x86.ActiveCfg = Release|x86
{825249DF-2022-4222-96A1-69A32AA4E16C}.Release|x86.Build.0 = Release|x86
{825249DF-2022-4222-96A1-69A32AA4E16C}.Release|x86.Deploy.0 = Release|x86
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|Any CPU.Build.0 = Debug|Any CPU
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|ARM.ActiveCfg = Debug|ARM
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|ARM.Build.0 = Debug|ARM
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|ARM64.ActiveCfg = Debug|ARM64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|ARM64.Build.0 = Debug|ARM64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|x64.ActiveCfg = Debug|x64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|x64.Build.0 = Debug|x64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|x86.ActiveCfg = Debug|x86
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Debug|x86.Build.0 = Debug|x86
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|Any CPU.ActiveCfg = Release|Any CPU
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|Any CPU.Build.0 = Release|Any CPU
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|ARM.ActiveCfg = Release|ARM
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|ARM.Build.0 = Release|ARM
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|ARM64.ActiveCfg = Release|ARM64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|ARM64.Build.0 = Release|ARM64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|x64.ActiveCfg = Release|x64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|x64.Build.0 = Release|x64
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|x86.ActiveCfg = Release|x86
{80207DE7-F5EF-4B47-9C81-E65DEA1D4832}.Release|x86.Build.0 = Release|x86
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down
10 changes: 4 additions & 6 deletions appLauncher/App.xaml.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
using appLauncher.Core.Helpers;
using appLauncher.Core.Pages;

using GoogleAnalyticsv4SDK.Validation;

using System;
using System.Threading.Tasks;

Expand All @@ -28,8 +26,8 @@ namespace appLauncher
sealed partial class App : Application
{
public static ApplicationDataContainer localSettings = ApplicationData.Current.LocalSettings;
public ExceptionEventCalls reportException;
public ScreenViewEventCalls reportScreenViews;
//public ExceptionEventCalls reportException;
//public ScreenViewEventCalls reportScreenViews;

/// <summary>
/// Initializes the singleton application object. This is the first line of authored code
Expand Down Expand Up @@ -81,8 +79,8 @@ protected override async void OnLaunched(LaunchActivatedEventArgs e)

//Extends view into status bar/title bar, depending on the device used.
await SettingsHelper.LoadAppSettingsAsync();
reportScreenViews = new ScreenViewEventCalls(SettingsHelper.totalAppSettings.MeasurementID, SettingsHelper.totalAppSettings.APISecret, SettingsHelper.totalAppSettings.ClientID);
reportException = new ExceptionEventCalls(SettingsHelper.totalAppSettings.MeasurementID, SettingsHelper.totalAppSettings.APISecret, SettingsHelper.totalAppSettings.ClientID);
////reportScreenViews = new ScreenViewEventCalls(SettingsHelper.totalAppSettings.MeasurementID, SettingsHelper.totalAppSettings.APISecret, SettingsHelper.totalAppSettings.ClientID);
////reportException = new ExceptionEventCalls(SettingsHelper.totalAppSettings.MeasurementID, SettingsHelper.totalAppSettings.APISecret, SettingsHelper.totalAppSettings.ClientID);
ApplicationView appView = ApplicationView.GetForCurrentView();
appView.SetPreferredMinSize(new Size(360, 360));
appView.SetDesiredBoundsMode(ApplicationViewBoundsMode.UseCoreWindow);
Expand Down
5 changes: 2 additions & 3 deletions appLauncher/Core/Helpers/imageHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
using Windows.System.Threading;
using Windows.UI;
using Windows.UI.Core;
using Windows.UI.Xaml;
using Windows.UI.Xaml.Media;

namespace appLauncher.Core.Helpers
Expand Down Expand Up @@ -84,7 +83,7 @@ public static async Task<List<PageBackgrounds>> LoadBackgroundImages()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}

Expand Down Expand Up @@ -114,7 +113,7 @@ public static async Task SaveImageOrder()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand Down
15 changes: 7 additions & 8 deletions appLauncher/Core/Helpers/packageHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
using Windows.Management.Deployment;
using Windows.Storage;
using Windows.Storage.Streams;
using Windows.UI.Xaml;

namespace appLauncher.Core.Helpers
{
Expand Down Expand Up @@ -58,7 +57,7 @@ public static async Task LoadCollectionAsync()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand Down Expand Up @@ -95,7 +94,7 @@ public static async Task LoadCollectionAsync()
});
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
es = null;
continue;
Expand Down Expand Up @@ -132,7 +131,7 @@ public static async Task LoadCollectionAsync()
});
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
es = null;
continue;
Expand All @@ -143,7 +142,7 @@ public static async Task LoadCollectionAsync()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand All @@ -165,7 +164,7 @@ public static async Task SaveCollectionAsync()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand Down Expand Up @@ -240,7 +239,7 @@ public static async Task RescanForNewApplications()
});
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
es = null;
continue;
Expand All @@ -251,7 +250,7 @@ public static async Task RescanForNewApplications()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}

}
Expand Down
4 changes: 2 additions & 2 deletions appLauncher/Core/Helpers/settingsHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public static async Task LoadAppSettingsAsync()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
//await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand All @@ -69,7 +69,7 @@ public static async Task SaveAppSettingsAsync()
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion appLauncher/Core/Model/GlobalAppSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public GlobalAppSettings()
Package pack = Package.Current;
PackageVersion version = new PackageVersion();
version = pack.Id.Version;
_appVersion = string.Format("{0}.{1}.{2}.{3}", version.Major, version.Minor, version.Build, version.Revision);
_appVersion = string.Format("{0}.{1}.{2}", version.Major, version.Minor, version.Build);

}
public bool Search
Expand Down
8 changes: 4 additions & 4 deletions appLauncher/Core/Pages/AboutPage.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
</RelativePanel>
<Grid Grid.Row="1">
<StackPanel Orientation="Vertical" Background="Transparent" >
<TextBox Background="Transparent" BorderThickness="0" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" IsReadOnly="True" Text="Original Maintainer: Colin Kiama" />
<TextBox Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" BorderThickness="0" HorizontalAlignment="Center" IsReadOnly="True" Text="Current Maintainer: Isaac Morris" />
<HyperlinkButton Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" Content="Source" NavigateUri="https://github.com/IsaacMorris1980/appLauncher" />
<HyperlinkButton Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" Content="Report Issue" NavigateUri="https://github.com/IsaacMorris1980/appLauncher/issues" />
<HyperlinkButton Background="Transparent" BorderThickness="0" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" Content="Original Maintainer: Colin Kiama" NavigateUri="https://github.com/colinkiama" />
<HyperlinkButton Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" BorderThickness="0" HorizontalAlignment="Center" Content="Current Maintainer: Isaac Morris" NavigateUri="https://github.com/IsaacMorris1980" />
<HyperlinkButton Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" Content="Source" NavigateUri="https://github.com/IsaacMorris1980/appLauncher/tree/Testing" />
<HyperlinkButton Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" Content="Report Issue" NavigateUri="https://github.com/IsaacMorris1980/appLauncher/issues" />
<TextBox BorderThickness="0" Background="Transparent" Foreground="{x:Bind helper:SettingsHelper.totalAppSettings.AppForegroundColorBrush}" HorizontalAlignment="Center" IsReadOnly="True" Text="{x:Bind appversion}" />
</StackPanel>
</Grid>
Expand Down
3 changes: 1 addition & 2 deletions appLauncher/Core/Pages/AboutPage.xaml.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
using appLauncher.Core.Helpers;

using Windows.UI.Xaml;
using Windows.UI.Xaml.Controls;
using Windows.UI.Xaml.Input;

Expand All @@ -24,7 +23,7 @@ private async void AboutPage_Loaded(object sender, Windows.UI.Xaml.RoutedEventAr
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportScreenViews.CollectScreenViews("About");
// await ((App)Application.Current).reportScreenViews.CollectScreenViews("About");
}

}
Expand Down
8 changes: 4 additions & 4 deletions appLauncher/Core/Pages/MainPage.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public MainPage()
}
catch (Exception es)
{
((App)Application.Current).reportException.CollectException(es).ConfigureAwait(false);
// ((App)Application.Current).reportException.CollectException(es).ConfigureAwait(false);
}

}
Expand Down Expand Up @@ -141,7 +141,7 @@ private async void SizeChangeTimer_Tick(object sender, object e)
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}

Expand Down Expand Up @@ -264,7 +264,7 @@ await Dispatcher.RunAsync(CoreDispatcherPriority.High,
, SettingsHelper.totalAppSettings.ImageRotationTime);
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportScreenViews.CollectScreenViews("Main");
// await ((App)Application.Current).reportScreenViews.CollectScreenViews("Main");
}
}
private async void disableScrollViewer(GridView gridView)
Expand All @@ -281,7 +281,7 @@ private async void disableScrollViewer(GridView gridView)
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportException.CollectException(es);
// await ((App)Application.Current).reportException.CollectException(es);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion appLauncher/Core/Pages/SettingsPage.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ private async void Page_Loaded(object sender, RoutedEventArgs e)
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportScreenViews.CollectScreenViews("Settings");
// await ((App)Application.Current).reportScreenViews.CollectScreenViews("Settings");
}

}
Expand Down
2 changes: 1 addition & 1 deletion appLauncher/Core/Pages/splashScreen.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ private async void SplashScreen_Loaded(object sender, RoutedEventArgs e)
{
if (SettingsHelper.totalAppSettings.Reporting)
{
await ((App)Application.Current).reportScreenViews.CollectScreenViews("Splash Screen");
// await ((App)Application.Current).reportScreenViews.CollectScreenViews("Splash Screen");
}
}

Expand Down
2 changes: 1 addition & 1 deletion appLauncher/Package.appxmanifest
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Package xmlns="http://schemas.microsoft.com/appx/manifest/foundation/windows10" xmlns:mp="http://schemas.microsoft.com/appx/2014/phone/manifest" xmlns:uap="http://schemas.microsoft.com/appx/manifest/uap/windows10" xmlns:iot="http://schemas.microsoft.com/appx/manifest/iot/windows10" xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities" IgnorableNamespaces="uap mp iot rescap">
<Identity Name="c7a9e123-47c7-47c2-9040-99dcd4ac7351" Publisher="CN=morri" Version="2.2.1.0" />
<Identity Name="c7a9e123-47c7-47c2-9040-99dcd4ac7351" Publisher="CN=morri" Version="2.2.3.0" />
<mp:PhoneIdentity PhoneProductId="c7a9e123-47c7-47c2-9040-99dcd4ac7351" PhonePublisherId="00000000-0000-0000-0000-000000000000" />
<Properties>
<DisplayName>appLauncher</DisplayName>
Expand Down
8 changes: 4 additions & 4 deletions appLauncher/appLauncher.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,10 @@
</PackageReference>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\GoogleAnalyticsv4SDKFor.Net\GoogleAnalyticsv4SDK\GoogleAnalyticsv4SDK.csproj">
<Project>{80207de7-f5ef-4b47-9c81-e65dea1d4832}</Project>
<Name>GoogleAnalyticsv4SDK</Name>
</ProjectReference>
<Reference Include="GoogleAnalyticsv4SDK, Version=1.0.0.0, Culture=neutral, processorArchitecture=MSIL">
<SpecificVersion>False</SpecificVersion>
<HintPath>..\..\GoogleAnalyticsv4SDKForUWP\GoogleAnalyticsv4SDK\bin\Release\GoogleAnalyticsv4SDK.dll</HintPath>
</Reference>
</ItemGroup>
<PropertyGroup Condition=" '$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' &lt; '14.0' ">
<VisualStudioVersion>14.0</VisualStudioVersion>
Expand Down