Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confused in the docs... What's literal and what's variable? #116

Closed
McFateM opened this issue Feb 22, 2018 · 2 comments
Closed

Confused in the docs... What's literal and what's variable? #116

McFateM opened this issue Feb 22, 2018 · 2 comments
Labels
Documentation Update the docs or kind request for documentation. enhancement

Comments

@McFateM
Copy link
Member

McFateM commented Feb 22, 2018

Working through the migration_guide.md and I'm frequently confused: What is to be taken literally, and what is "variable"? An example from Step 2 of the aforementioned document:

The docker-compose.yml file found within /opt/ISLE/config/enduser-renamed-directory-prod.institution is ready for editing to "point" to these data directories. This process will be explained in further detail in Step 6 of this guide.

Overall, I find this paragraph, and some others, invoke more questions than answers.

In my case, I have no /opt/ISLE/config/enduser-renamed-directory-prod.institution directory, but I did find an isle-prod-project.institution directory at that location. Is one of these names "literal", not to be modified, or are one or both "variable"?

A suggestion... Is it too late to adopt a convention here? Maybe using {curly braces} to wrap elements of the text that are "variable"? If that were the case, then my interpretation, right or wrong, of the paragraph above would read something like this:

The docker-compose.yml file found within /opt/ISLE/config/{enduser-renamed-directory}-prod.{institution} is ready for editing to "point" to these data directories. This process will be explained in further detail in Step 6 of this guide.

Assuming a convention like this, I'd expect to find other references to {enduser-renamed-directory} and {institution} elsewhere in the document, and perhaps in some of the code, and I would expect to give all matching {variables} the same value.

Another case in point... there's a section of migration_guide.md with a directory tree diagram like so:

Example future directory structure:

  /path_to/isle_production_data_storage/
           |
           ├──enduser-renamed-directory-dev.institution
           |  ├── apache  
           |  ├── fedora   
           |  ├── mysql  
           |  └── solr  
           |
           ├──enduser-renamed-directory-prod.institution
           |  ├── apache  
           |  ├── fedora   
           |  ├── mysql  
           |  └── solr  
           |
           ├──enduser-renamed-directory-stage.institution
           |  ├── apache  
           |  ├── fedora   
           |  ├── mysql  
           |  └── solr     
           |

When I worked through that section of the document I assumed something like this:

Example future directory structure:

  /{mount}/isle_production_data_storage/
           |
           ├──{enduser-renamed-directory}-dev.{institution}
           |  ├── apache  
           |  ├── fedora   
           |  ├── mysql  
           |  └── solr  
           |
           ├──{enduser-renamed-directory}-prod.{institution}
           |  ├── apache  
           |  ├── fedora   
           |  ├── mysql  
           |  └── solr  
           |
           ├──{enduser-renamed-directory}-stage.{institution}
           |  ├── apache  
           |  ├── fedora   
           |  ├── mysql  
           |  └── solr     
           |

And I made the following "global" substitutions in my build...

  • {mount} = mnt
  • {enduser-renamed-directory} = dg
  • {institution} = grinnell

Comments? Suggestions?

@hamhpc
Copy link
Member

hamhpc commented Feb 22, 2018 via email

@McFateM McFateM added enhancement Documentation Update the docs or kind request for documentation. labels Feb 23, 2018
@dmer
Copy link
Contributor

dmer commented Feb 23, 2018

We discussed this morning adding glossary of terms and variables - this can be a separate page in the docs that defines some of the more basic terminology and also has all of the "variables" called out and explained

marksandford added a commit to ColgateUniversity/ISLE that referenced this issue May 20, 2019
…ollaboration-Group/dwk2-patch-3

update isle-cheatsheet-docker-commands.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update the docs or kind request for documentation. enhancement
Projects
None yet
Development

No branches or pull requests

4 participants