You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think having a viable product takes precedent; to that end I don't believe anything in this ticket needs action now, none of this is a blocker.
Hi - I was looking through some of the Dockerfiles and had a few thoughts!
Container Level (subfolders)
I still have an overall folder structure question: would it be possible for Container folders to contain their Dockerfile, and a single consolidated folder for all configs (even if that folder has children, this is especially true on multi-daemon containers). Reading the Dockerfile it is easier to understand seeing COPY file from a config folder to a destination on the container, or a "lib" folder being copied to the lib location on the container, etc.
ISLE-MYSQL I think can be removed from the images entirely and left in the services definition. Are we maintaining a customized version of MySQL? I can totes provide an example - this is the easiest way for me.
ISLE-FEDORA is perhaps the most challenging as it might as well be called "core" and it hosts more than one daemon. The layers in this box are incredible. :jaw-drop: (needs to be a thing)
ISLE-WEB: again, lots of layers, but here we're using intermittent builds! Nice!
organize folders in a coherent manner for their containers
deprecate "MAINTAINER" and use LABELS per Docker.
Can ISLE-MY be deprecated?
network consideration (should be at the services level, Ben)
I'll update as I go but sorry, these are some of the thoughts now!
The text was updated successfully, but these errors were encountered:
@br2490 I've updated all Dockerfiles to use LABELS now via this commit
The other elements of your original post should be discussed with the steering committee I think given we're in the Alpha stage and I'd prefer a more orderly way of patching, refactoring etc.
(I do think you have some good points here just think they should be addressed with the group!)
I think having a viable product takes precedent; to that end I don't believe anything in this ticket needs action now, none of this is a blocker.
Hi - I was looking through some of the Dockerfiles and had a few thoughts!
Container Level (subfolders)
I still have an overall folder structure question: would it be possible for Container folders to contain their Dockerfile, and a single consolidated folder for all configs (even if that folder has children, this is especially true on multi-daemon containers). Reading the Dockerfile it is easier to understand seeing COPY file from a config folder to a destination on the container, or a "lib" folder being copied to the lib location on the container, etc.
ISLE-MYSQL I think can be removed from the images entirely and left in the services definition. Are we maintaining a customized version of MySQL? I can totes provide an example - this is the easiest way for me.
ISLE-FEDORA is perhaps the most challenging as it might as well be called "core" and it hosts more than one daemon. The layers in this box are incredible. :jaw-drop: (needs to be a thing)
ISLE-WEB: again, lots of layers, but here we're using intermittent builds! Nice!
I'll update as I go but sorry, these are some of the thoughts now!
The text was updated successfully, but these errors were encountered: