Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post-alpha cleanup and consolidation @ isle containers level #64

Closed
2 of 4 tasks
br2490 opened this issue Dec 5, 2017 · 2 comments
Closed
2 of 4 tasks

post-alpha cleanup and consolidation @ isle containers level #64

br2490 opened this issue Dec 5, 2017 · 2 comments
Labels
Documentation Update the docs or kind request for documentation. enhancement

Comments

@br2490
Copy link
Member

br2490 commented Dec 5, 2017

I think having a viable product takes precedent; to that end I don't believe anything in this ticket needs action now, none of this is a blocker.

Hi - I was looking through some of the Dockerfiles and had a few thoughts!

Container Level (subfolders)

I still have an overall folder structure question: would it be possible for Container folders to contain their Dockerfile, and a single consolidated folder for all configs (even if that folder has children, this is especially true on multi-daemon containers). Reading the Dockerfile it is easier to understand seeing COPY file from a config folder to a destination on the container, or a "lib" folder being copied to the lib location on the container, etc.

ISLE-MYSQL I think can be removed from the images entirely and left in the services definition. Are we maintaining a customized version of MySQL? I can totes provide an example - this is the easiest way for me.

ISLE-FEDORA is perhaps the most challenging as it might as well be called "core" and it hosts more than one daemon. The layers in this box are incredible. :jaw-drop: (needs to be a thing)

ISLE-WEB: again, lots of layers, but here we're using intermittent builds! Nice!

  • organize folders in a coherent manner for their containers
  • deprecate "MAINTAINER" and use LABELS per Docker.
  • Can ISLE-MY be deprecated?
  • network consideration (should be at the services level, Ben)

I'll update as I go but sorry, these are some of the thoughts now!

@g7morris
Copy link
Member

g7morris commented Dec 7, 2017

@br2490 I've updated all Dockerfiles to use LABELS now via this commit

The other elements of your original post should be discussed with the steering committee I think given we're in the Alpha stage and I'd prefer a more orderly way of patching, refactoring etc.

(I do think you have some good points here just think they should be addressed with the group!)

@br2490
Copy link
Member Author

br2490 commented Feb 17, 2018

I'm closing this ticket as we're well past this and other issues and I'm in favor of a cleaner queue.

@br2490 br2490 closed this as completed Feb 17, 2018
marksandford added a commit to ColgateUniversity/ISLE that referenced this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update the docs or kind request for documentation. enhancement
Projects
None yet
Development

No branches or pull requests

2 participants