Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate out the more OS-specific parts of the scripts to make porting easier #2

Open
ruebot opened this issue Oct 1, 2015 · 2 comments

Comments

@ruebot
Copy link
Contributor

ruebot commented Oct 1, 2015

From @lo5an on March 19, 2015 18:4

If there's interest in eventually supporting additional Linux distributions like CentOS, then it might make sense to put the more OS-specific parts of the scripts into their own files.

Copied from original issue: Islandora-Labs/islandora_vagrant#23

@ruebot
Copy link
Contributor Author

ruebot commented Oct 1, 2015

This is definitely a good topic for the next DevOps IG call.

I have some thoughts around how we could implement this, and wanted to run it by the group. tl;dr wrap all OS-specifc parts in if statements, add if statements to Vagrantfile, and tie that all to a build environment variable. So, vagrant up OS=Ubuntu would get you Ubuntu.

All that said, if anybody wants to claim this work, they should 😄

@ruebot
Copy link
Contributor Author

ruebot commented Oct 1, 2015

From @AndrewGearhart on May 20, 2015 21:6

Seems the best way to support this (as vagrant doesn't support other command line arguments) is to use environment variables. so, it would be something along the lines of

os=ubuntu vagrant up

and in the vagrantfile

 if ENV['os'].nil?
      stuff for if there's no OS selected
    else
      stuff for if there is an OS identified (would need to check for whether the selected OS is supported or not)
    end

I think this is a cool option, but my head is swimming with the number of variances for the different OS options (and their package managers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant