Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghostscript Update #32

Merged
merged 7 commits into from Jul 6, 2018
Merged

Ghostscript Update #32

merged 7 commits into from Jul 6, 2018

Conversation

lutaylor
Copy link
Contributor

@lutaylor lutaylor commented Jun 7, 2018

JIRA Ticket:
https://jira.duraspace.org/browse/ISLANDORA-2035

What does this Pull Request do?

Updates Ghostscript to latest version 9.23 which should allow for compression.

What's new?

Updated Ghostscript version to the latest.

How should this be tested?

vagrant up
gs -v
Should show Ghostscript version 9.23.
If it shows any other version or the gs -v command fails to run then the test should be considered failed.

The box should be re-exported to ensure it still works with latest Islandora.

As per Islandora-Labs/islandora_vagrant#127

Ingest 2 newspapers (ideally multiple pages)
Using a PDF
1st newspaper PDF should use the PAGE IMAGE SETTINGS at the upload page of 48-bit RGB, 150 DPI or 300 DPI with Extract text from the PDF
2nd newspaper PDF should use the PAGE IMAGE SETTINGS at the upload page of 32-bit CMYK, 300 DPI with Extract text from the PDF
Check if derivatives were properly generated

Additional Notes:

Completely optional PR we might want to think about sticking with 9.10 just for legacy reasons since it is still being maintained for security patches by Ubuntu.

Either way, we should be able to close out Issue link Islandora-Labs/islandora_vagrant#127

Interested parties

@DonRichards @Islandora-Labs/committers

@DonRichards
Copy link
Member

@lutaylor Under the "How should this be tested" section is should say what would fail if this Ghostscript change fails?

@DonRichards DonRichards self-requested a review June 18, 2018 19:01
@DonRichards DonRichards self-assigned this Jun 18, 2018
@lutaylor
Copy link
Contributor Author

@DonRichards
I added some more to the test case.

@DonRichards
Copy link
Member

OK, thanks. I'll take a look.

@DonRichards
Copy link
Member

@lutaylor 2 questions. How do you suggest I test if upgrading Ghostscript isn't breaking anything (image ingest, book, etc) and would you mind correcting the code travis is complaining about?

@DonRichards
Copy link
Member

Sorry, I know it sounds a little dumbed down asking what should be tested but I have found it immensely helpful in the past. So small changes like this might have massive effects on seemingly unrelated functions.

@lutaylor
Copy link
Contributor Author

lutaylor commented Jul 3, 2018

Your test case mentioned here should do perfectly Islandora-Labs/islandora_vagrant#127

Ingest 2 newspapers (ideally multiple pages)
Using a PDF
1st newspaper PDF should use the PAGE IMAGE SETTINGS at the upload page of 48-bit RGB, 150 DPI or 300 DPI with Extract text from the PDF
2nd newspaper PDF should use the PAGE IMAGE SETTINGS at the upload page of 32-bit CMYK, 300 DPI with Extract text from the PDF
Check if derivatives were properly generated

Ok to use this?

@lutaylor
Copy link
Contributor Author

lutaylor commented Jul 3, 2018

I fixed the travis check.

Copy link
Member

@DonRichards DonRichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work thanks!

@lutaylor
Copy link
Contributor Author

lutaylor commented Jul 4, 2018

@DonRichards
I see you approved the changes did you want to merge?

@DonRichards DonRichards merged commit 291401e into Islandora-Labs:master Jul 6, 2018
@DonRichards
Copy link
Member

Apologies. Meant to merge it yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants