New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ghostscript Update #32
Conversation
@lutaylor Under the "How should this be tested" section is should say what would fail if this Ghostscript change fails? |
@DonRichards |
OK, thanks. I'll take a look. |
@lutaylor 2 questions. How do you suggest I test if upgrading Ghostscript isn't breaking anything (image ingest, book, etc) and would you mind correcting the code travis is complaining about? |
Sorry, I know it sounds a little dumbed down asking what should be tested but I have found it immensely helpful in the past. So small changes like this might have massive effects on seemingly unrelated functions. |
Your test case mentioned here should do perfectly Islandora-Labs/islandora_vagrant#127
Ok to use this? |
I fixed the travis check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work thanks!
@DonRichards |
Apologies. Meant to merge it yesterday. |
JIRA Ticket:
https://jira.duraspace.org/browse/ISLANDORA-2035
Islandora/islandora_paged_content@723004b
ISLANDORA-2053: Update travis.yml to force PHP 5.3.3 to run under Ubuntu Precise Islandora/islandora_paged_content#137
Issue link Included GhostScript version (9.10) fails to extract PDF pages on RGB format islandora_vagrant#127
What does this Pull Request do?
Updates Ghostscript to latest version 9.23 which should allow for compression.
What's new?
Updated Ghostscript version to the latest.
How should this be tested?
vagrant up
gs -v
Should show Ghostscript version 9.23.
If it shows any other version or the gs -v command fails to run then the test should be considered failed.
The box should be re-exported to ensure it still works with latest Islandora.
As per Islandora-Labs/islandora_vagrant#127
Additional Notes:
Completely optional PR we might want to think about sticking with 9.10 just for legacy reasons since it is still being maintained for security patches by Ubuntu.
Either way, we should be able to close out Issue link Islandora-Labs/islandora_vagrant#127
Interested parties
@DonRichards @Islandora-Labs/committers