Update symfony/flex. #144
Merged
Update symfony/flex. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #144 +/- ##
=========================================
Coverage 76.60% 76.60%
Complexity 161 161
=========================================
Files 6 6
Lines 654 654
=========================================
Hits 501 501
Misses 153 153 Continue to review full report at Codecov.
|
|
Still seem to be getting the same error on composer install and also update: vagrant@islandora8:/var/www/html/Crayfish/Houdini$ composer install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
In PackageFilter.php line 125:
Undefined index: splits
install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
vagrant@islandora8:/var/www/html/Crayfish/Houdini$ git branch
2.x
* 2.x-ISLANDORA-2079
dev
vagrant@islandora8:/var/www/html/Crayfish/Houdini$ |
|
The GitHub page referencing this error mentions that symfony/flex should be at least version 1.17. On this PR's branch it's at 1.13. $ composer info symfony/flex
name : symfony/flex
descrip. : Composer plugin for Symfony
keywords :
versions : * v1.13.3
type : composer-plugin
license : MIT License (MIT) (OSI approved) https://spdx.org/licenses/MIT.html#licenseText
homepage :
source : [git] https://github.com/symfony/flex.git 2597d0dda8042c43eed44a9cd07236b897e427d7
dist : [zip] https://api.github.com/repos/symfony/flex/zipball/2597d0dda8042c43eed44a9cd07236b897e427d7 |
|
Thanks for catching @alxp derped on |
|
Updated and tested on fresh Playbook install. Was able to see Service File mp4, so this update does not seem break Crayfish's functionality.
|
alxp
approved these changes
Apr 7, 2022
whikloj
added a commit
to whikloj/Crayfish
that referenced
this pull request
Sep 16, 2022
whikloj
pushed a commit
to whikloj/Crayfish
that referenced
this pull request
Sep 16, 2022
* Update symfony/flex. * Actually update the require.
seth-shaw-asu
pushed a commit
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2079
What does this Pull Request do?
Updates
symfony/flexthat's required due to an end-of-life of their previous download manager.What's new?
Version bump.
How should this be tested?
Houdini should still operate as expected.
Interested parties
@alxp