ISLANDORA-1042 -- DESTROY ALL DEPRECATED CODE! #545
Conversation
| * @return NewFedoraObject | ||
| * The new object. | ||
| */ | ||
| function islandora_ingest_form_prepare_new_object(array $configuration) { |
There was a problem hiding this comment.
We shouldn't delete it yet as it's still in use in the same module:
https://github.com/ruebot/islandora/blob/7.x-ISLANDORA-1042/includes/ingest.form.inc#L85
There was a problem hiding this comment.
Put it back with 690fb4c.
There was a problem hiding this comment.
I think that use is for the deprecated 'object' entry and should be removed, which would let this removal go through.
There was a problem hiding this comment.
So, roll back 690fb4c?
and remove https://github.com/ruebot/islandora/blob/7.x-ISLANDORA-1042/includes/ingest.form.inc#L84-L86?
There was a problem hiding this comment.
I think so and maybe cleaning up $objects initialization.
There was a problem hiding this comment.
innocently asks what's wrong with $object initialization
There was a problem hiding this comment.
I don't think the ternary is necessary anymore.
|
Just so this isn't missed (it's in a closed diff): #545 (comment) |
…unction islandora_ingest_form.
|
Re-removed function and the other call to it. |
|
Looks like this is going to pass Travis. So, if you (speaking to anybody who reviews this, not a specific you) check out the two recent commits, if the ternary is removed, we have problems downstream on ingest that I noticed on a smoke test: Putting it back in seems to make everything happy. |
Simplification as single object entry is deprecated.
|
Just gathering stuff for the Committers Call this week. Is this still a thing? Why is this still a thing? |
|
Just needs to be merged. |
|
This looks good to me. |
ISLANDORA-1042 -- DESTROY ALL DEPRECATED CODE!
No description provided.