Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D9 islandora #809

Merged
merged 77 commits into from
Dec 18, 2020
Merged

D9 islandora #809

merged 77 commits into from
Dec 18, 2020

Conversation

elizoller
Copy link
Member

@elizoller elizoller commented Nov 23, 2020

Ticket: Islandora/documentation#1680
THIS PR depends on #816

What does this Pull Request do?

Updates Islandora Core for Drupal 9 support

What's new?

  • remove deprecated functions
  • insert new functions
  • use dependency injection
  • clean up for php codesniffer
  • updates travis to php 7.4
  • updates context, migrate_source_csv, and flysystem to versions that supports d9
  • temporarily point to crayfish-commons branch that supports d9 and php 7.4
  • updates migration source config (keys => ids)
  • includes an update hook for updating migration config

How should this be tested?

Checkout the PR
Do a cache clear
Make sure you can do normal islandora stuff - make a node/media/file and have them all persist to fedora properly, get derivatives, etc.
Pass all the tests
Note that updatedb must be run
Due to dependency chain, I think this will only work on a d9 site

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

@Islandora/8-x-committers @kayakr @jordandukart

@elizoller
Copy link
Member Author

i think this is ready for a review now. let me know of anything i missed or incorrectly fixed.

@elizoller
Copy link
Member Author

i think the dependencies are now failing due to :
Root composer.json requires islandora/islandora dev-travis-testing as dev-8.x-1.x -> satisfiable by islandora/islandora[dev-travis-testing]
when it would need to look at islandora/islandora:dev-d9_islandora

@manez
Copy link
Member

manez commented Dec 17, 2020

This has got to be in the running for most commits on a single islandora PR 😄

Thanks so much for all of this work, @elizoller !

@dannylamb
Copy link

We are green. Let's do this!

@dannylamb dannylamb merged commit 7f0d54e into Islandora:8.x-1.x Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants