Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple breadcrumb parent fields #873

Merged
merged 4 commits into from
May 18, 2022
Merged

Multiple breadcrumb parent fields #873

merged 4 commits into from
May 18, 2022

Conversation

seth-shaw-unlv
Copy link

GitHub Issue: N/A

What does this Pull Request do?

  • Exposes the breadcrumbs configuration in a form page.
  • Allows the breadcrumbs builder to use multiple entity reference fields for finding parents
  • Fixes a breadcrumbs builder error when the 'includeSelf' configuration is true.

What's new?

  • Changes islandora_breadcrumbs.breadcrumbs schema to allow multiple reference fields instead of just one. Includes an update hook.
  • Changes the breadcrumbs builder to use multiple reference fields the update config schema allows
  • Added a form for updating breadcrumbs settings.
  • Fixed an error that was causing the site to crash when the includeSelf option was true.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (i.e. Regeneration activity, etc.)? Run the Drupal database update to execute the update hook.
  • Could this change impact execution of existing code? No.

How should this be tested?

  • Create some nodes with the member_of field and verify the breadcrumbs work as expected
  • Apply the PR
  • Run the Drupal update (e.g. drush updatedb -y)
  • Ensure the breadcrumbs are still working
  • Change some settings on the new form @ /admin/config/islandora/breadcrumbs
  • Ensure the changes work for the breadcrumbs
  • Add another entity reference field
  • Add that field to the breadcrumbs configuration
  • Populate that field on a node and verify it is used for building breadcrumbs

Documentation Status

  • Does this change existing behaviour that's currently documented? No.
  • Does this change require new pages or sections of documentation? I don't think so.
  • Who does this need to be documented for?

Interested parties

@Islandora/committers, esp. @jordandukart

@seth-shaw-unlv seth-shaw-unlv changed the title Multiple parents Multiple breadcrumb parent fields May 17, 2022
@jordandukart
Copy link
Member

Will try to get to this today @seth-shaw-unlv!

@jordandukart jordandukart merged commit 1a13b3e into Islandora:2.x May 18, 2022
@seth-shaw-unlv seth-shaw-unlv deleted the multiple-parents branch May 18, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants