ISLANDORA-1555 #216
Merged
ISLANDORA-1555 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've checked and run this code locally. Okay with the update as the component manager; would like some confirmation slash someone to merge. |
|
@qadan, looks fine for me, it's a simple but very effective change. 👍 Thanks! |
| $doi_url = parse_url(trim($url)); | ||
| // Remove "/" from the path if it's the first or last character in the path. | ||
| $doi_url['path'] = rtrim($doi_url['path'], '/'); | ||
| $doi_url['path'] = ltrim($doi_url['path'], '/'); |
There was a problem hiding this comment.
A thought: could just use regular trim()? To ... haha ... trim down the number of lines here?
( •_•)
( •_•)>⌐■-■
(⌐■_■)
pinging @adam-vessey for pun approval
|
Changes look okay to me; I'd say this is ready to get merged in. |
|
👍 I'm happy to hit the merge button if everybody is cool with it. |
|
With no comments to the contrary, it seems like this can be merged? |
|
👍 to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://jira.duraspace.org/browse/ISLANDORA-1555
What does this Pull Request do?
It's an improvement to the DOI to allow for the full DOI URL to be used when getting the DOI data.
How should this be tested?
Ingest some objects using the DOI importer.
Old formats should continue to work:
DOI:10.1016/j.jorganchem.2011.11.018
10.1016/eva.12339
In addition to the old formats you should now be able to enter the records using full DOI urls:
http://dx.doi.org/10.1111/eva.12339
http://doi.org/10.1111/eva.12340
Additional Notes:
Tagging: @qadan, @ruebot, @DiegoPino, @mjordan
Matthew Perry
Developer
discoverygarden inc. | Managing Digital Content