Use metadata search as a facet - 7.x-ISLANDORA-1425

[whikloj]

Addresses ISLANDORA-1425

[whikloj]

@adam-vessey I'd appreciate a look over this if you have a chance, as it was your code originally. In case I am missing something.

[whikloj]

@bradspry Can you also have a look at this?

[bradspry]

@whikloj Tested your fix, it absolutely does work, but I recommend switching from urlencode() to rawurlencode() on line 239, to truly urlencode space characters as %20, per RFC 3986.

[jordandukart]

Any particular reason this being changed to be a facet query?

[whikloj]

@jordandukart it seemed to make it easier to deal with the internal data from the MODS record in much the same way it is handled in the faceting. The whole issue comes around the escaping of all the crazy stuff you get in MODS records you don't get people typing in a simple search box.

That said I'm not tied to it, but it worked.

[whikloj]

@adam-vessey, does this look good to you?

[adam-vessey]

Why not just use l()?

[whikloj]

Because that seemed to take me back to the original problem of double encoding of some characters.

[adam-vessey]

Is that referring to previous experimentation, appending to the path parameter itself in different ways?

l() effectively degrades to this (assuming links aren't being taken over in the theme):

function l($text, $path, array $options = array()) {
  // [... figure out $use_theme and handle "active" class ...] 
  if ($use_theme) {
    return theme('link', array('text' => $text, 'path' => $path, 'options' => $options));
  }
  // The result of url() is a plain-text URL. Because we are using it here
  // in an HTML argument context, we need to encode it properly.
  return '<a href="' . check_plain(url($path, $options)) . '"' . drupal_attributes($options['attributes']) . '>' . ($options['html'] ? $text : check_plain($text)) . '</a>';
}

@ in t()/format_string() == check_plain()

[whikloj]

Yes, yes it was. Fair point, I have updated to use l() instead of url().

[adam-vessey]

Looks good.

[whikloj]

Thanks @adam-vessey, @bradspry do you want to confirm this solves the problem you experienced?

[ruebot]

@bradspry can you confirm for @whikloj?

[bradspry]

@ruebot, @whikloj, I apologize, I did not catch the comment 9 days ago! Tested just now and all is well! (y)

Subsequent facet links work, everything is rawurlencoded(), its a beautiful thing:

/islandora/search?type=dismax&f[0]=mods_subject_name_personal_namePart_ms%3AKing%2C\%20Martin\%20Luther%2C\%20Jr.%2C\%201929\-1968&f[1]=mods_subject_topic_ms%3A%22African\%20Americans\-\-Social\%20conditions%22

[ruebot]

Thanks @bradspry!

@whikloj can you do a 7.x-1.6 pull request? I'll merge this one now.