Match the function signature. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JojoVes can you refer to https://jira.duraspace.org/browse/ISLANDORA-2040 in the Pull message ,you can keep both if you want of course? I prefer avoiding duplicated ones to avoid over-counting "fixed bugs" but i'm also ok if you want to have both. Thanks! |
|
Code seems in order. |
|
@DiegoPino I added that other ticket to the message. :) |
|
@JojoVes merged. Thanks for this. closed the tickets also. good work 👍 |
cuhk-library
added a commit
to cuhk-library/islandora_solution_pack_compound
that referenced
this pull request
Sep 6, 2017
Match the function signature. (Islandora#127)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: ISLANDORA-2041 and ISLANDORA-2040
What does this Pull Request do?
Makes sure the function signatures match.
What's new?
Not much. It should be fairly simple.
How should this be tested?
Regression test TN derivative creation
Interested parties
@Islandora/7-x-1-x-committers