ISLANDORA-1380: Change scroll implementation #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://jira.duraspace.org/browse/ISLANDORA-1380 Islandora Vagrant Machine uses up to date versions for every drupal Module. Jquery_update 3 Alpha-2 is one of those + Chrome interpretation of certain not standard JS makes scrollbars on Form Editor (treepanel) not being loaded. This triggers a false calc. on panel height/offset making the toolbar for manipulating form elements "disappear". Since we can't assure a specific JS interpretation/future compatibility for every interacting module with our old ExtJS( the main JS framework used by form builder and with many bugs) we removed the JS scrollbars replacing this with an css implementation. Tested on offending browsers and firefox.
|
Smoke tested and looks good. @whikloj second thumbs up? @DiegoPino can I get a release branch PR too? 😄 |
|
@ruebot Done, pull to 7.x-1.6 waiting for travis. |
Copied same value as used by MainPanel. I was sloppy...
|
👍 |
|
waits on Travis |
ruebot
added a commit
that referenced
this pull request
Sep 11, 2015
ISLANDORA-1380: Change scroll implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.duraspace.org/browse/ISLANDORA-1380
Islandora Vagrant Machine uses up to date versions for every drupal
Module. Jquery_update 3 Alpha-2 is one of those + Chrome interpretation
of certain not standard JS makes scrollbars on Form Editor (treepanel)
not being loaded. This triggers a false calc. on panel height/offset
making the toolbar for manipulating form elements "disappear". Since we
can't assure a specific JS interpretation/future compatibility for
every interacting module with our old ExtJS( the main JS framework used
by form builder and with many bugs) we removed the JS scrollbars
replacing this with an css implementation. Tested on offending
browsers and firefox.