New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Text find in all resources #119

Closed
TheExDeus opened this Issue Jun 25, 2014 · 10 comments

Comments

Projects
None yet
3 participants
@TheExDeus

TheExDeus commented Jun 25, 2014

Not a bug, but a feature which would be massively useful would be doing search in all code resources. GM allowed searching in all scripts only (at least in GM8.1) and LGM doesn't allow searching globally at all. This is very useful for debugging, like when you need to find all instances of "d3d_set_culling" in the project.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Sep 30, 2014

Collaborator

@TheExDeus I have begun laying the foundation as of 8eb131f

The feature is intended to work as we've discussed on the forums.
http://enigma-dev.org/forums/index.php?topic=2228.0

Collaborator

RobertBColton commented Sep 30, 2014

@TheExDeus I have begun laying the foundation as of 8eb131f

The feature is intended to work as we've discussed on the forums.
http://enigma-dev.org/forums/index.php?topic=2228.0

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Oct 1, 2014

Collaborator

@IsmAvatar I would like to prod you about making GmTreeGraphics work for both the resource tree and the search results tree. Josh was simply wanting to copy the behavior and allow the same nodes in both trees, but I don't think it is smart at all to use ResNode as a search result node when it has all the unnecessary overhead.

We plan to put the following tree proposed by @JoshDreamland into the new tab in the new LGM also pictured below titled "Search Results"
Tree Search
New LGM

I would also like to ask your proposal on making the search result nodes open the correct event, action, or moment frame with their relevant resource.

Everything else is already completed, the frames, the regexp matcher by @JoshDreamland, we just need to discuss how to layout this new tree.

Collaborator

RobertBColton commented Oct 1, 2014

@IsmAvatar I would like to prod you about making GmTreeGraphics work for both the resource tree and the search results tree. Josh was simply wanting to copy the behavior and allow the same nodes in both trees, but I don't think it is smart at all to use ResNode as a search result node when it has all the unnecessary overhead.

We plan to put the following tree proposed by @JoshDreamland into the new tab in the new LGM also pictured below titled "Search Results"
Tree Search
New LGM

I would also like to ask your proposal on making the search result nodes open the correct event, action, or moment frame with their relevant resource.

Everything else is already completed, the frames, the regexp matcher by @JoshDreamland, we just need to discuss how to layout this new tree.

@IsmAvatar

This comment has been minimized.

Show comment
Hide comment
@IsmAvatar

IsmAvatar Oct 1, 2014

Owner

Not sure what kind of input you need fro me. Sounds like you have a plan.

I do, however, feel that this idea hasn't been fleshed out completely enough yet or not to my satisfaction.

I would like to discuss this with you guys (preferably not here so as not to flood the ticket with chatter)

As far as new nodes go, I agree with you, a new node object would probably make more sense to prevent introducing all the overhead from ResNode and to prevent polluting ResNode with additional functionality. If they share functionality, to reduce duplicate code you may want to make a parent class for both of them.

Owner

IsmAvatar commented Oct 1, 2014

Not sure what kind of input you need fro me. Sounds like you have a plan.

I do, however, feel that this idea hasn't been fleshed out completely enough yet or not to my satisfaction.

I would like to discuss this with you guys (preferably not here so as not to flood the ticket with chatter)

As far as new nodes go, I agree with you, a new node object would probably make more sense to prevent introducing all the overhead from ResNode and to prevent polluting ResNode with additional functionality. If they share functionality, to reduce duplicate code you may want to make a parent class for both of them.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Oct 3, 2014

Collaborator

@IsmAvatar @TheExDeus The preview of the new search functionality has gone live in the newest LGM release and 26d63db, it is however not completed. The following needs done before it is finished.

  • Search All Resources
  • Add Clipboard Functions
  • Allowing Clicking on Nodes
  • Result nodes should have scope, eg. open the correct event/moment/action and go to the correct line
  • Obtain IsmAvatar Approval

Please see the forum topic for the download.
http://enigma-dev.org/forums/index.php?topic=2269

Collaborator

RobertBColton commented Oct 3, 2014

@IsmAvatar @TheExDeus The preview of the new search functionality has gone live in the newest LGM release and 26d63db, it is however not completed. The following needs done before it is finished.

  • Search All Resources
  • Add Clipboard Functions
  • Allowing Clicking on Nodes
  • Result nodes should have scope, eg. open the correct event/moment/action and go to the correct line
  • Obtain IsmAvatar Approval

Please see the forum topic for the download.
http://enigma-dev.org/forums/index.php?topic=2269

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Oct 29, 2014

Collaborator

@IsmAvatar and @TheExDeus As of f9972c2 and a101690 Objects and Timelines are both searchable now.

Collaborator

RobertBColton commented Oct 29, 2014

@IsmAvatar and @TheExDeus As of f9972c2 and a101690 Objects and Timelines are both searchable now.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Oct 31, 2014

Collaborator

Search In All Resources

@IsmAvatar @TheExDeus As of the last update the search feature is basically completed, see the forum for more details.
http://enigma-dev.org/forums/index.php?topic=2269.msg23589#new

I guess the only thing now is for @IsmAvatar to sign off on this.

Collaborator

RobertBColton commented Oct 31, 2014

Search In All Resources

@IsmAvatar @TheExDeus As of the last update the search feature is basically completed, see the forum for more details.
http://enigma-dev.org/forums/index.php?topic=2269.msg23589#new

I guess the only thing now is for @IsmAvatar to sign off on this.

@IsmAvatar

This comment has been minimized.

Show comment
Hide comment
@IsmAvatar

IsmAvatar Nov 1, 2014

Owner

You have my blessing. If I think of any improvements now, they shouldn't be hard to implement. Good work.

Owner

IsmAvatar commented Nov 1, 2014

You have my blessing. If I think of any improvements now, they shouldn't be hard to implement. Good work.

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Nov 2, 2014

Collaborator

@IsmAvatar Thank you, as of 2604155 we also have preferences added to the preferences frame for the search highlighting and I've also addressed more of egofree's exceptions, but I am waiting for the next release until me and Josh finish this new icon pack.

Preferences Frame Revamp

Collaborator

RobertBColton commented Nov 2, 2014

@IsmAvatar Thank you, as of 2604155 we also have preferences added to the preferences frame for the search highlighting and I've also addressed more of egofree's exceptions, but I am waiting for the next release until me and Josh finish this new icon pack.

Preferences Frame Revamp

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Nov 2, 2014

Collaborator

@IsmAvatar @TheExDeus Final version released, just testing and stability now.
http://enigma-dev.org/forums/index.php?topic=2269.msg23627#msg23627

Collaborator

RobertBColton commented Nov 2, 2014

@IsmAvatar @TheExDeus Final version released, just testing and stability now.
http://enigma-dev.org/forums/index.php?topic=2269.msg23627#msg23627

@RobertBColton

This comment has been minimized.

Show comment
Hide comment
@RobertBColton

RobertBColton Dec 10, 2014

Collaborator

This feature is completely finished and everyone loves it, I've fixed all bugs in it I've found. I also updated the Portable ZIP with this new LGM.
http://enigma-dev.org/forums/index.php?topic=2364

I am going to close this, if any other issues crop up with the feature or you think of something new then open a new ticket.

Collaborator

RobertBColton commented Dec 10, 2014

This feature is completely finished and everyone loves it, I've fixed all bugs in it I've found. I also updated the Portable ZIP with this new LGM.
http://enigma-dev.org/forums/index.php?topic=2364

I am going to close this, if any other issues crop up with the feature or you think of something new then open a new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment