Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the views preview #126

Merged
merged 32 commits into from Jul 17, 2014
Merged

Improving the views preview #126

merged 32 commits into from Jul 17, 2014

Conversation

egofree71
Copy link
Collaborator

In the rooms editor, when a view is selected in the views list, it is displayed now centered in the room. Also, the 'Object to follow' property is now taken into account with the border zone too.
In preference settings, the 'Undo history size' has been added. If you put 0, the undo is disabled, and if you put -1 it will be unlimited.

account the visual offset of the border and the zoom level.
view coordinates for the new viewport coordinates
follow' coordinates for each view in the room.
follow' coordinates when there is no instances to follow.
@RobertBColton
Copy link
Collaborator

Very nice ego, will test it when I have time. But I did want to see a screenshot of it with inverted colors to see if that's more recognizable.

@JPierreS
Copy link

I agree with the inverted colour, (which should be optional too),
but also (that might be stretching it) but for multiple views, putting the number on the corner of the box to identify what view number (0-7) the rectangular area covers.
Yes I know rectangled is not a word, whatever :D

Edit: Use rectangular you silly goose.

@egofree71
Copy link
Collaborator Author

RobertBColton,Darkstar2 :
Why not, but first let's accept my pull request ! :-)
A remark concerning the 'object to follow' option : it is based on the first instance of the object in the room. If you are in the 'views' tab, you can't modify objects, and the views will be always up-to-date. If you activate the 'show views' option in the rooms editor menu, it calculates again the views position with the first instance, and it's fine. But then if you modify some objects instances in the room, the views with 'object to follow' option set will not be updated automatically. It would be overkill to do this. This would mean that every time we modify an object instance, we have to check if there is a view with an instance of this object and test if this instance is the first in the room. I know that in LateralGM there is some mechanisms to link automatically properties, but in this case i don't think it would work. Indeed, the view is linked to an 'object' not to an instance, so this link is 'fragile'. (Ideally the view 'Object to follow' option should be linked to an instance, but it's not really needed, because it was just made for following the player).
But i don't think it's a big deal, as the user can go in the views tab or deactivate and activate the 'show views' option, and see the result of his modification, and anyway this option was made 99% of the time for following the player.

@egofree71
Copy link
Collaborator Author

I've added the border zone preview, and the 'undo history size' setting.
IsmAvatar : if you are reading this comment, i would be grateful if you could commit this pull request.

IsmAvatar added a commit that referenced this pull request Jul 17, 2014
Improving the views preview
@IsmAvatar IsmAvatar merged commit c538935 into IsmAvatar:master Jul 17, 2014
@IsmAvatar
Copy link
Owner

Merging after a brief review, and positive feedback.

@IsmAvatar
Copy link
Owner

Also, @egofree71 would appreciate it if you could take a look at #127

@egofree71
Copy link
Collaborator Author

Robert:
For a screenshot with inverted colors : http://enigma-dev.org/forums/index.php?topic=2082.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants