Fixes HintTextField Related Issues #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clipping bounds of the graphics object are affected by the drop down menu's. Using them to clip the input hint caused the menu bar to clip the text off. It seems that the component itself uses its own bounds for clipping in the look and feel code, so I did it that way. It appears to have resolved the issue with the web look and feel.
It should use the baseline of the font like the default look and feel does. I tested all look and feels and examined before and after in Paint.NET. The input hint is now drawn in the proper location. I also corrected the behavior of hide on focus, so the feature can be properly disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were problems with clipping and where the location of where the input hint was being drawn. I tested all look and feels and also tested on Ubuntu with Java 8 and this seems to address all of the issues.