Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and fixes GMX reader #314

Merged
merged 3 commits into from Oct 1, 2016
Merged

Cleanup and fixes GMX reader #314

merged 3 commits into from Oct 1, 2016

Conversation

RobertBColton
Copy link
Collaborator

@RobertBColton RobertBColton commented Oct 1, 2016

The most important change here is that I have made the GMX reader finally more fault tolerant than the GMK file reader. No longer do I just lob all exceptions up and exit as early as possible, I attempt to handle errors as they occur. For example, if the subframe image for some sprite can't be read, an error dialog will be displayed but the file reader will continue reading other resources. So the user is still informed of the error but it doesn't stop you from loading the whole project.

Also if the XML parser fails to parse a resource's XML file, you will still get the resource added to the tree, but none of its data is loaded.

I also used the DefaultPostponedRef class in a few places to reduce the code bloat since they were all doing the same thing anyway. That was the purpose of that class.

I also fixed an issue where the default exception handler was printing the thread name after the exception stack trace. The thread name should have been printed to the error stream not the standard output stream.

@RobertBColton RobertBColton merged commit 837b146 into IsmAvatar:master Oct 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant