Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icon to new one used by MS Teams #134

Closed
julian-alarcon opened this issue May 14, 2019 · 0 comments
Closed

Update icon to new one used by MS Teams #134

julian-alarcon opened this issue May 14, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
0.3.0

Comments

@julian-alarcon
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
MS Teams updated its icon, just update icon to new assets

Describe the solution you'd like
We need to refresh icons in png located in build/icons and app/icons/ paths

Describe alternatives you've considered
This is not a bit issue, but is related to have a similar approach to the current official version.

Additional context
From the source code of current web version with new icons I got the new files (but not in all the current resolutions)

<link rel="icon" type="image/png" href="https://statics.teams.microsoft.com/hashedassets/favicon/prod/favicon-32x32-04b7d908.png"/>
<link rel="icon" type="image/png" href="https://statics.teams.microsoft.com/hashedassets/favicon/prod/favicon-16x16-aedbfeac.png"/>
<link rel="icon" type="image/png" href="https://statics.teams.microsoft.com/hashedassets/favicon/prod/favicon-96x96-6b9521ce.png"/>
<link rel="shortcut icon" type="image/x-icon" href="https://statics.teams.microsoft.com/hashedassets/favicon/prod/favicon-34ed16c5.ico" />

Also, I already updated the icon in the Snap store. https://snapcraft.io/teams-for-linux/
@julian-alarcon julian-alarcon added enhancement New feature or request good first issue Good for newcomers labels May 14, 2019
@julian-alarcon julian-alarcon added this to To do in 0.3.0 via automation May 14, 2019
0.3.0 automation moved this from To do to Done May 14, 2019
@IsmaelMartinez IsmaelMartinez mentioned this issue May 27, 2019
Merged
IsmaelMartinez added a commit that referenced this issue May 27, 2019
@IsmaelMartinez
0.3.0 (#140)
210cf55 
# General notes

This release is been mostly focus on automating the release to snapcraft. 

Also, now the spellchecker works with a local version of hunspell installed (if located under /usr/share/hunspell/)

The icon has been also updated to the latest MS one.

A couple of new features added to be able to start the app minimised and having the webDebug option in the tray menu.

# Detail changes

* #92 Using gitflow from now on for releases (having master and develop branches) (Thanks to @julian-alarcon)
* #74 automating the snap release (Thanks to @julian-alarcon and @benyanke)
* #121 Fixing snap and camera not working together (Thanks to @julian-alarcon)
* #118, #113 and #119 Unpacking the spellchecker dictionaries and adding the ones installed in hunspell (Thanks to @vadimi and @noderat )
* #134 Updating the MS icon (Thanks to @julian-alarcon)
* #91 removing the apparmor=DENIED messages in syslog for snap build (Thanks to @julian-alarcon)
* #137 Adding the --minimized option to start the app minimized (Thanks to @didster)
* #135 Adding webDebug to the tray menu options (Thanks to @Fmstrat)

Also:
* #109 At the moment the propagation of 'about:blank' links has been disabled to minimise annoyance from this issue.

And the packages versions has been updated a bit, as we got a blocker for moving to version 5 or electron.


# Thanks

To everyone involved from people reporting issues, testing solutions and implementing them. You all make this possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
0.3.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julian-alarcon