Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made a package for the Raspberry PI 4 but have one small issue #359

Closed
franz-strebel opened this issue May 22, 2020 · 11 comments
Closed

Comments

@franz-strebel
Copy link

franz-strebel commented May 22, 2020

Thanks for the great work on this unofficial Teams client. npm start works well on my Pi 4 from source so I wanted to package it so other Pi owners can install it easily. I got the package done but when I install from it, I do not have Screen sharing, which I get when running from source.

Would be great if you can point me in the right direction. Thank you.

@IsmaelMartinez
Copy link
Owner

yeah, feel free to share.

I now use github actions to do builds so maybe that is a way to integrate/test it?

@franz-strebel
Copy link
Author

OK, I got it done and packaged for arm64 as I am running Ubuntu 20.04 on my Pi 4. How do I send you the packages for posting?

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented May 25, 2020

I @franz-strebel, Thanks a lot for your work.

To avoid you needing to publish a build image every time I do a release, I had a play with github actions and electron-builder to see if the build can do it for us automatically.

Can you check the following version and see if the raspberry one works? https://github.com/IsmaelMartinez/teams-for-linux/releases/tag/v1.0.5

@franz-strebel
Copy link
Author

franz-strebel commented May 26, 2020

That's great, thanks @IsmaelMartinez ! I switched back to Raspbian as I had some programs unavailable for arm64. I just tested the deb package and AppImage you built for armv7l and I have the same issue, they work but I do not have Screen sharing.
However, when I run npm start from your source, I have that and it works very well. Any idea why there is this difference?
I will prepare another arm64 set up to test the packages for that arch and let you know. Thanks again!

@IsmaelMartinez
Copy link
Owner

There should not be a difference. My only question is, does it take a long time to start up? We enable the "screen sharing" after 4 seconds (I think). If it takes a wee bit longer it might get overwritten by MS code.
Let me know if that is the case and we can allow to tweak that number in the config.

@franz-strebel
Copy link
Author

From the package and AppImage, I don't have the icon at all for screen sharing. With npm start, I see the icon greyed out first and then it becomes active.

@franz-strebel
Copy link
Author

Tried running with webDebug and I do see this at startup if it helps:

Screenshot_2020-05-26_13-06-58

@IsmaelMartinez
Copy link
Owner

can you try running the packaged version without the spellchecker?

teams-for-linux --rightClickWithSpellcheck=false

it smells like the spellchecker is not being compiled/packaged properly... (needs pre-compilation) https://github.com/IsmaelMartinez/teams-for-linux/blob/develop/app/browser/index.js#L12

Just a guess..

@franz-strebel
Copy link
Author

Yes, that does the trick. I gave it a go by putting the spellchecker from the pi to my other machine for the build and disabling npmRebuild but didn't have much luck. Thanks again.

@IsmaelMartinez
Copy link
Owner

well, not the end of the world I guess... but there is no right click then!

@IsmaelMartinez
Copy link
Owner

version 1.0.5 is now released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants