screenSharingControlService: unexpected, cannot find the call #432
Comments
|
I can confirm this for Ubuntu 20.04. Still works in Chrome. |
|
Same here in Archlinux, version 1.0.6, from the AUR. Everything works on (ungoogled-)chromium. Tried the |
|
Hi all, I suspect MS has deprecated the browser support for that version. Unfortunately, that means solving the problem requires quite a lot of work. Happy to review PRs and/or have a chat with anyone willing to fix this. I currently have a MacBook Pro (work...) so canna really do the full work, but I offer my support and/or guidance. |
|
maybe try with other user agents. replacing the "yournewuseragent" for something other than "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3202.75 Safari/537.36" and starting the app like this : If you find a userAgent that works the fix is fairly simple. |
|
It works with user agent: Is there a reason why it was downgraded in commit 7d799b6? |
|
The explanation is in the PR #409 Basically, screensharing stopped working then. That might have changed (would not be the 1st time they do that). can you confirm screensharing does work when executing: If that is the case, that commit/pr is a good example of what needs to be done. I will be happy to release a Pre-release with it and see if anyone complains (and then release it). Thanks for checking! |
|
I tested without success under Ubuntu 20.10 with version 1.0.6 with this cmd line : @Surowa how did you make it work ? |
|
I tested without more success on Archlinux. I also contacted Microsoft about official App that is not working neither and the answer was basically that only Ubuntu 18.04/20.04, Fedora 30 and CentOS 8 was supported. I don't know if it is related. Maybe a different graphic package? |
|
To elaborate in the reasoning of the moving to version 71. In this limits page: Did indicated screensharing not available for browsers prior v72 We then moved back as the implementation change from ms teams means they didn't try to use the browser extension that we are using to "plug-in" the screensharing. Arguveably, someone could implement the screensharing in a better way using a newer version of electron, but that would be quite a bit of work. Happy to help but I can't lead the development (apologies, no time in my hand). But I am happy to share my knowledge and provide support if people gets stuck. Thanks in advance! |
|
Hi all, looks like @jijojosephk found a workaround for the screensharing issue. I got no time, apologies, but happy to review and approve/merge PRs |
|
@IsmaelMartinez PR is generated. Could you try? I've upgraded all modules to latest version. Fixed some migration related issues and our screen sharing issue. |
|
Hi all. @jijojosephk , I have tried your version on Archlinux with nodejs-lts-fermium, and i get the following error in terminal: Tried with electron 12.0.9, 6.1.12 and 7.3.3. I have built the app using yarnpkg. Edit: On one hand, screen sharing does not work on my machine, nor sharing selector window. On an other hand, something is happening now in the terminal, it was not the case before. Seems the problem is being narrowed down? |
|
Tested your branch @jijojosephk, and it runs fine on Ubuntu 20.04 (compiled on a docker container). I tested sharing of my screen without issue. I can select the monitor to share (multi screen). Thanks for the work ! |
|
@DrasLorus Isn't the application opening at all? My development environment is Ubuntu 20.04. LTS, Node 14.17.1, NPM 7.17.0, Electron 13.1.2 |
Thank you. Currently, it considers only screen. I can include windows as well. I would generate another PR after that. Glad that my work helped somebody. Good day! |
I'll wait for your next PR, thanks ! |
|
@jijojosephk it is! Everything else works fine with the Maybe I build it wrong... EDIT: Modifications on the screenshot |
|
@DrasLorus the documentation says to use I personally used |
I've pushed the changes. Could you try? |
These messages are logged even for me., spellchecker module has some issues. Not compatible with latest electron. But suppressed with turning off a flag. You may see that in the commit. It should be OK if application is working and not getting crashed. When teams is opened in chrome browser, you would see a lot of errors in console window as well. |
Single window sharing works perfectly 👍 There are two minor points :
Thanks for the work ! Edit: typo |
Could you share some screenshots if possible? |
Aaaand it works. Thanks a lot. |
|
Does it work with latest versions of nodejs? |
|
@frealgagu It's tested on Node 14 and npm 7 running under Ubuntu 20.04 |
Same as @skyghis , working in ArchLinux, thanks a lot @jijojosephk |
I changed the screen sharing view from BrowserWindow to BrowserView. Got less time on UI fine tuning. Could you give a try? I'll push another PR. |
Just one thing, it will not show you 2K or 4K if the primary display does not support it. In your case, you would only see HD & FHD. Additional 2 will be shown to users who are having higher resolution displays. |
|
Will Request Control/Give Control work as well now? |
Currently it's not working that way. I'll investigate how that works in Chrome browser. If it's working there, then there's some hope for investigation and possibly finding the solution. |
|
@IsmaelMartinez @jijojosephk tested the pre-release version today, didnt notice any issues so far |
@joakim-tjernlund on Google Chrome it does not show anything like that. Just a small floating component which let's you know that you're sharing screen. |
|
@jijojosephk , OK that was not totally unexpected. |
|
This hints that some Control should be possible: https://docs.microsoft.com/en-us/microsoftteams/troubleshoot/teams-conferencing/give-control-doesn%E2%80%99t-work-sharescreen |
I have not faced any issues with audio. Communications with such interfaces varies between OS I've seen issues with official teams application as well. Probably it's there. My headphone is always connected :) |
Thanks for sharing. I'll have a look at this if it's possible in Chromium engine through Electron we'll definitely handle it. |
I could not make it work on browser. But the official client works well in this case. It shows a red boarder on the screen and also a tool bar with stop sharing and things like that. |
|
I've tested it with a custom AUR build in Manjaro and it works great, great job from @jijojosephk! |
AFAIK, this feature is not available on browser. The text where they talk about browsers is just to provide an easy way to check GPU acceleration for their electron instance. |
|
Anyone tested with pipewire? I know there is an issue with MS Teams and pipewire. |
In my case I'm using PipeWire 0.3.30 on Manjaro with no issues at all. Webcam, screen sharing and audio is OK. Just the already known annoying focus bug from PipeWire, but nothing else. |
I haven't used PipeWire. Is the focus bug you're talking about is on screenshare preview? |
Yes, when I select sharing screen, all the windows focuses very fast (to get a preview of each window I guess) and Teams is left unfocused "at the back of the desktop", so you have to focus it again using alt+Tab or your task bar. It's a bit annoying but it is not a blocking bug and I think it is not related to this project. A possible workaround could be trying to refocus the Teams window after the preview generation, but I'm not sure if this is feasible. |
I see. I had created a new issue in electron repo here a few days ago. I'll try to find some workarounds. Thank you. @IsmaelMartinez I'd add this as an issue here. So, we'll keep track of it. |
|
@IsmaelMartinez @skyghis @neokore Focus issue is handled at #440 and has a workaround for now. This is how it looks. All other windows run panicky and teams window just stands there solid. 😄 |
Is there any specific setup needed in order to make pipewire screen sharing work? I really want to use wayland session but not able to screen share is a no go. |
|
I've tested the 4K Resolution with 4K main screen and it works :-D |
4K genuinely improves quality over FHD or somewhat similar? Was recipient using 4K? Really curious to know the outcome 😄 . Well, 2K is less popular and is wide screen. Both 2K and FHD has the same height only width changes. May be the aspect ratio is causing some troubles for 2K. |
|
@jijojosephk we saw no difference between 4k and FHD on the other side. But we're really happy to have window's sharing back 👍 |
|
@alfsch, 2K and 4K were experimental. I guess Teams web app along with WebRTC and/or teams APIs interfere with quality. May be it's not supported at the moment. But when the future comes, we're ready 😄 Glad that I could be a help to this group. |
|
Ok! I have customized the AUR PKGBUILD to build directly from the git clone of the develop branch (available as I have also tested on Wayland (with sway) and screen-sharing don't work, neither on XWayland nor in pure Wayland (using Funny point: no loose of focus under Wayland. 😃 So Wayland is unaffected or its associated bugs/incompatibilities compensate or conflict with what causes the focus lost. Everything else than screen-sharing seems to work well. |
|
@DrasLorus The focus issue is handled here #440 It's a workaround though. It would keep the teams window active though you see some strange things happen behind the window. |
|
1.0.8 worked for me with sharing screens (4K display, shared at 1080p, didn't try the higher options since there's not really any point). Thanks for the fix! |
|
closed as 1.0.8 its out. Thanks a lot @jijojosephk for the resolution and everyone else for testing this. |
Describe the bug
It looks like screen sharing stopped working recently. It worked fine last week, this week it stopped working. Perhaps something changed on the Teams website in an incompatible way?
To Reproduce
Try sharing the screen in a meeting. After clicking "Desktop/Window", nothing happens.
Desktop (please complete the following information):
teams-for-linuxin the Archlinux AURAdditional context
Developer console:
Full log:
The text was updated successfully, but these errors were encountered: