Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making calls grabs multimedia keys #716

Closed
bmaupin opened this issue Mar 27, 2023 · 1 comment · Fixed by #717
Closed

Making calls grabs multimedia keys #716

bmaupin opened this issue Mar 27, 2023 · 1 comment · Fixed by #717

Comments

@bmaupin
Copy link
Contributor

bmaupin commented Mar 27, 2023

Describe the bug

Making a call in Teams binds the multimedia keys (play/pause/etc) to Teams so that they no longer work with media applications (e.g. Spotify).

To Reproduce
Steps to reproduce the behavior:

  1. Open a media application (e.g. Spotify) and start playing music
  2. Press the play/pause multimedia key to make sure the key works with the media application
  3. Open Teams for Linux
  4. Make a call in Teams
  5. End the call
  6. Press the play/pause multimedia key and observe that the key no longer has any effect on the media application

Expected behavior

Since Teams isn't a media application, it should have no impact on the multimedia keys

Screenshots

N/A

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Installation package: deb
  • Version: 1.0.49

Additional context

Electron seems to bind to the multimedia keys by default.

It seems that this can be disabled relatively easily:

app.commandLine.appendSwitch('disable-features', 'HardwareMediaKeyHandling');

(electron/electron#18253 (comment))

bmaupin added a commit to bmaupin/teams-for-linux that referenced this issue Mar 27, 2023
@jijojosephk
Copy link
Collaborator

@bmaupin this went unnoticed. there were some merges happened. Could you pull again and also update the version in package.json?

bmaupin added a commit to bmaupin/teams-for-linux that referenced this issue Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants