Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add join meeting via link outside application #255

Merged
merged 4 commits into from Aug 26, 2019
Merged

feat: add join meeting via link outside application #255

merged 4 commits into from Aug 26, 2019

Conversation

emanuelbatista
Copy link
Contributor

issue: #253

IsmaelMartinez
IsmaelMartinez requested changes Aug 26, 2019
View reviewed changes
Copy link
Owner

@IsmaelMartinez IsmaelMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st of all, thanks a lot for taking the time to look into this and fix it! I added a wee changes.

I will be offline for a few days but, once I am back, I will look forward to see this working!

Thanks a lot!

app/mainAppWindow/index.js Show resolved Hide resolved
app/mainAppWindow/index.js Outdated Show resolved Hide resolved
app/mainAppWindow/index.js Show resolved Hide resolved
app/mainAppWindow/index.js Show resolved Hide resolved
app/mainAppWindow/index.js Outdated Show resolved Hide resolved
emanuelbatista
emanuelbatista commented Aug 26, 2019
View reviewed changes
Copy link
Contributor Author

@emanuelbatista emanuelbatista left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are done

@IsmaelMartinez
Copy link
Owner

IsmaelMartinez commented Aug 26, 2019 •
edited

Added just one wee question/comment. Once that it's done I can merge it to develop (so it goes to the snap edge channel). Thanks again!!

@IsmaelMartinez IsmaelMartinez merged commit c4f10e6 into IsmaelMartinez:develop Aug 26, 2019
@IsmaelMartinez IsmaelMartinez added this to In progress in 1.0.0 via automation Aug 26, 2019
@IsmaelMartinez IsmaelMartinez added the enhancement New feature or request label Aug 26, 2019
@IsmaelMartinez IsmaelMartinez moved this from In progress to Done in 1.0.0 Aug 26, 2019
@IsmaelMartinez IsmaelMartinez mentioned this pull request Aug 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsmaelMartinez IsmaelMartinez IsmaelMartinez approved these changes

Assignees

@emanuelbatista emanuelbatista

Labels
enhancement New feature or request
Projects
No open projects
1.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emanuelbatista @IsmaelMartinez