Implemented reliable tray updates #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexeiskachykhin . Thanks for this PR, and for, indirectly, showing me how to hook in those services. I will try to review this at some point this week and merge. Depending on other changes, it will be out this week or next week. Thanks again! |
|
Hey @IsmaelMartinez thank you for accepting the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @IsmaelMartinez this pull request addresses the problem that I observed on Ubuntu 16.04.5 where a tray icon wouldn't update on unread messages. This implementation relies on Teams API to get notified instead of obtaining unread notification based on page title change.
I tested it on Ubuntu 16.04.5 and Ubuntu 18.04.2.