Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature views #6

Merged
merged 5 commits into from
Sep 2, 2023
Merged

Feature views #6

merged 5 commits into from
Sep 2, 2023

Conversation

IsmailChangezi
Copy link
Owner

Description

  • Add views for Post and User Models
  • Add Some changes to the controllers
  • Fix Linter Errors

Copy link

@rloterh rloterh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved ✔️

Hi Ismail,

Your project is complete! 🏁There is nothing else to say other than... it's time to merge it 🍾 Congratulations! 🎉💯🌟

Highlights 🎯

🎲 Views properly implemented!

Optional suggestions 🧰

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.

  • [OPTIONAL]
    A user without a post is not being saved in the correctly due to improper post_counter validation. Please endeavor to resolve the error thrown below in an attempt to save a user without a post

image

Cheers..Happy coding! 💻 🍷 🚀

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

@IsmailChangezi IsmailChangezi merged commit 400e31b into dev Sep 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants