-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"routeLoaded" just for some nested routes, not for all #57
Comments
Are you using route parameters? It may be possible, that the routeLoaded() is not firing when a parameter of the url changes. |
Hey @frederikhors are you trying to listen to |
I'm doing it right now. But you also know that it is a bit ugly, right? |
@frederikhors I have just pushed a better fix to master (will be released in version 2.0) that allows you to pass custom objects using the |
This changed the syntax of the route pre-condition functions as well as the data passed to the routeLoaded and conditionsFailed callbacks. Fixes ItalyPaleAle#44, ItalyPaleAle#57 Breaking change
@ItalyPaleAle, I agree with you about the few (amazing) basic features that make this router great.
For the
window.scrollTo(0, 0)
problem (#49) your hint to use the newrouteLoaded
function is great and I'm using it right now like this:But it works for every underlying route.
And maybe this is a new problem now.
How to use it only for some
<Router>
(parent) components?The text was updated successfully, but these errors were encountered: