Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokerstars Cashout Support #98

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Conversation

RuijieZ
Copy link

@RuijieZ RuijieZ commented Dec 4, 2023

  • Pokerstars cashout support + Unit tests
  • One hand sample file

@ItalyToast
Copy link
Owner

looks like you're not parsing the insurance fee.

@RuijieZ
Copy link
Author

RuijieZ commented Dec 5, 2023

It seems like Pokerstars notation is different from GG.

In GG:

Actual winning= Insurance pay out - Insurance fee.

Pokerstars:

Actual winning = Insurance pay out.

The insurance fee is already subtracted, the hand history is just letting the player know how much is substracted.

I will update the PR to make sure we are using consistent notation in both.

@ItalyToast
Copy link
Owner

I will update the PR to make sure we are using consistent notation in both.

The value in the handaction/winningsaction should be the change in stack for the player. Which would be "Actual winning" in your example. The values should be correct then (if I understood it correctly).

I'll merge the PR if you dont want to add the Insurance fee.

@ItalyToast ItalyToast merged commit 3eb27e0 into ItalyToast:master Dec 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants