Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB - 6865] - Keychain null crash fix #635

Merged
merged 3 commits into from
Oct 3, 2023

Commits on Sep 21, 2023

  1. [MOB - 6865] - Keychain null crash fix

    - Handles condition where IterableKeychain creation returns null to Iterable API.
    SDK will continue to process without crashing.
    There will be no email fetched from sharedPreferences in this rare case. No email will be persisted and the app will have to setEmail/setUserId on every app session for it to have email in memory than having it persisted for consequent app sessions
    
    - Fixed indentation on IterableKeychain file. Using cmd+l on Android Studio
    
    - Added method description in IterableConfig class so developers have more context on what `setEncryptionEnforced` means
    
    - getKeychain is now annotated @nullable for future kotlin migration purpose
    “Akshay committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    61943df View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Catching Error along with Exception

    1. Checking for Throwable which will collect both Exception and Error if at all Security library is crashing with a Error and not exception.
    2. Updating the dependency to use latest alpha version. Alpha version 5 also seems to fix race condition during creation process.
    Reference - https://developer.android.com/jetpack/androidx/releases/security#1.1.0-alpha05
    3. Added some warning logs if this situation arrives so developers can take some action if it occurs during debugging
    “Akshay committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f8a8fa9 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Merge pull request #637 from Iterable/MOB-6865-add-on-changes

    Catching Error along with Exception
    Ayyanchira committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    8d5b427 View commit details
    Browse the repository at this point in the history