Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump axios from 0.21.4 to 1.6.2 #247

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

ptessier
Copy link
Contributor

@ptessier ptessier commented Dec 11, 2023

Description

Bump axios to resolve GHSA-wf5p-g6vw-rhxx

Relied on unit tests to make sure it works.

@ptessier
Copy link
Contributor Author

@mprew97 Are you planning on merging my PRs? Just trying to plan if I'm waiting on this to be merged or if I should patch your package.

@mprew97
Copy link
Contributor

mprew97 commented Dec 27, 2023

Hey @ptessier, apologies for the delay on this. I actually was working on bundling a whole bunch of dependency issues and it's taken me longer than expected to get them tested and deployed. For the sake of time, I will test this PR first thing when I'm back this Tuesday and merge/deploy this.

@ptessier
Copy link
Contributor Author

Thanks for the heads up. If you have some time, I also have two other PRs with small changes we patched in our repo.

Copy link
Contributor

@mprew97 mprew97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved

@mprew97 mprew97 merged commit 0e6675a into Iterable:main Jan 2, 2024
1 check passed
@mprew97
Copy link
Contributor

mprew97 commented Jan 2, 2024

@ptessier working on cutting the release for this and your other PRs. Thanks for your patience here. Will hopefully have it released by EOD today or tomorrow.

@ptessier
Copy link
Contributor Author

ptessier commented Jan 2, 2024

@mprew97 Wow amazing, thanks!

@ptessier ptessier deleted the ptessier/bump-axios branch January 2, 2024 20:30
@mprew97
Copy link
Contributor

mprew97 commented Jan 3, 2024

@ptessier changes are now packaged and released in v1.0.7.

@ptessier
Copy link
Contributor Author

ptessier commented Jan 8, 2024

@mprew97 Seems like the auth is failing after bumping to v.1.0.7

@ptessier
Copy link
Contributor Author

ptessier commented Jan 8, 2024

Seems like it might be related to the axios version that is bundled in the library.

@mprew97
Copy link
Contributor

mprew97 commented Jan 9, 2024

@ptessier I'm not seeing any immediate issues with our own auth after bumping. Please open a separate issue with reproducibles if you are still experiencing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants