refactor git tag step

Iterable · Jan 5, 2024 · 61ab702 · 61ab702
1 parent 6f95d2e
commit 61ab702
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/.github/workflows/ios-sdk-release.yml b/.github/workflows/ios-sdk-release.yml
@@ -48,6 +48,9 @@ jobs:
       - name: create xcframeworks and zip
         run: bundle exec fastlane ios build_xcframework output_dir:./output_dir
 
+      - name: create and push git tag
+        run: bundle exec fastlane ios create_git_tag version:$VERSION
+
       - name: create github release and upload assets
         run: |
           bundle exec fastlane ios create_release version:$VERSION branch:$BRANCH changelog_section:$CHANGELOG_SECTION output_dir:$OUTPUT_DIR github_token:$GITHUB_TOKEN set_prerelease:$SET_PRERELEASE

diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -14,6 +14,7 @@ platform :ios do
     bump_release_version(version:set_version)
     clean_and_lint
     build_xcframework(output_dir:set_output_dir)
+    create_git_tag(version:set_version)
     create_release(version:set_version, output_dir:set_output_dir, changelog_section:set_changelog_section, github_token:set_github_token)
     pod_trunk_push
   end 
@@ -77,6 +78,14 @@ platform :ios do
     )
   end
 
+  desc "create git tag and push tag"
+  lane :create_git_tag do |options|
+    version = options[:version]
+
+    add_git_tag(tag: "#{version}")
+    push_git_tags
+  end
+
   desc "create github release and upload assets"
   lane :create_release do |options|
     version = options[:version]
@@ -86,8 +95,6 @@ platform :ios do
     github_token = options[:github_token]
     set_prerelease = options[:set_prerelease]
 
-    add_git_tag(tag: "#{version}") 
-
     version_changelog = read_changelog(
       changelog_path: 'CHANGELOG.md',
       section_identifier: "[#{changelog_section}]",