Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOB-153] - Update to Swift 4.2 #45

Merged
merged 2 commits into from
Feb 1, 2019

Conversation

tapashmajumder
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #45 into stable will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           stable      #45     +/-   ##
=========================================
- Coverage   90.51%   90.42%   -0.1%     
=========================================
  Files          26       26             
  Lines        1097     1097             
=========================================
- Hits          993      992      -1     
- Misses        104      105      +1
Impacted Files Coverage Δ
swift-sdk/Internal/IterableAPIInternal.swift 89.58% <ø> (-0.42%) ⬇️
...-sdk/Internal/IterableAppIntegrationInternal.swift 88.88% <ø> (ø) ⬆️
swift-sdk/IterableAPI.swift 98.41% <ø> (ø) ⬆️
...sdk/Internal/IterableInAppHTMLViewController.swift 92.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2f3582...8009c15. Read the comment docs.

Copy link
Contributor

@vbabenkoru vbabenkoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tapashmajumder tapashmajumder merged commit ad6ddb3 into stable Feb 1, 2019
@tapashmajumder tapashmajumder deleted the feature/mob-153-upgrade-to-swift-4_2 branch February 1, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants