test with codecov #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| jobs: | ||
| test: | ||
| name: Test |
There was a problem hiding this comment.
It is better to name it "Code coverage"
README.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|  | |||
| [](https://crates.io/crates/martos) | |||
| [](https://github.com/IvanArkhipov1999/Martos/releases) | |||
| [](https://codecov.io/gh/Azernem/Task-manager-and-timer) | |||
There was a problem hiding this comment.
Why is it path to another repository?
tests/integration_tests.rs
Outdated
Comment on lines
1
to
3
| // <copyright file="integration_tests.rs" company="NematMusaev"> | ||
| // Copyright (c) PlaceholderCompany. All rights reserved. | ||
| // </copyright> |
There was a problem hiding this comment.
Hm, copyright in files is a good idea, but not this copyright.
| // <copyright file="task_manager_tests.rs" company="NematMusaev"> | ||
| // Copyright (c) PlaceholderCompany. All rights reserved. | ||
| // </copyright> | ||
| struct TaskDispatcher { |
There was a problem hiding this comment.
It seems a typo is here. And I don't understand, what this tests test.
| @@ -0,0 +1,40 @@ | |||
| pub struct Timer { | |||
There was a problem hiding this comment.
And here I don't understand, what are you testing
tests/unit_tests.rs
Outdated
| @@ -1,3 +1,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
Why is this unit tests?
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| profile: minimal | ||
| toolchain: nightly |
There was a problem hiding this comment.
I don't understand a lot from this ci, could you give a reference to documentation in answer, please? For example, I don't understand, why you need nightly toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.