Fix detekt and remove dummy features

Ivy-Apps · May 16, 2024 · f031500 · f031500
1 parent 3c52811
commit f031500
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 21 deletions.
diff --git a/screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt b/screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
@@ -919,14 +919,14 @@ class EditTransactionViewModel @Inject constructor(
 
     private suspend fun sortCategories(): ImmutableList<Category> {
         val categories = categoryRepository.findAll()
-        val shouldSortCategoriesAlphabetically = shouldSortCategoriesAlphabetically()
-            ?: return categories.toImmutableList()
-        return if (shouldSortCategoriesAlphabetically)
+        return if (shouldSortCategoriesAlphabetically()) {
             categories.sortedBy { it.name.value }.toImmutableList()
-        else categories.toImmutableList()
+        } else {
+            categories.toImmutableList()
+        }
     }
 
-    private suspend fun shouldSortCategoriesAlphabetically(): Boolean? {
-        return features.sortCategoriesAlphabetically.enabled(context).firstOrNull()
+    private suspend fun shouldSortCategoriesAlphabetically(): Boolean {
+        return features.sortCategoriesAlphabetically.enabled(context).firstOrNull() ?: false
     }
 }
diff --git a/shared/domain/src/main/java/com/ivy/domain/features/Features.kt b/shared/domain/src/main/java/com/ivy/domain/features/Features.kt
@@ -1,8 +1,6 @@
 package com.ivy.domain.features
 
 interface Features {
-    val homeV2: BoolFeature
-    val compactTransactions: BoolFeature
     val sortCategoriesAlphabetically: BoolFeature
 
     val allFeatures: List<BoolFeature>

diff --git a/shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt b/shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
@@ -5,17 +5,6 @@ import javax.inject.Singleton
 
 @Singleton
 class IvyFeatures @Inject constructor() : Features {
-    override val homeV2 = BoolFeature(
-        key = "home_v2",
-        name = "Home screen v2",
-        description = "Activate the new Home screen."
-    )
-    override val compactTransactions = BoolFeature(
-        key = "compact_transaction",
-        name = "Compact transactions",
-        description = "Smaller transactions cards" +
-            " so you can fit more on your screen."
-    )
     override val sortCategoriesAlphabetically = BoolFeature(
         key = "sort_categories_alphabetically",
         name = "Sort Categories Alphabetically",
@@ -25,8 +14,6 @@ class IvyFeatures @Inject constructor() : Features {
 
     override val allFeatures: List<BoolFeature>
         get() = listOf(
-            homeV2,
-            compactTransactions,
             sortCategoriesAlphabetically
         )
 }