[BUG] Incorrect addition on account transfer

[pravissw]

Please confirm the following

• I checked the current issues for duplicate problems

Describe the bug

One of my accounts had a balance of 32.45€. I transferred 167.55€ from another account to make it 200€. Adding this on ivy wallet somehow results in ivy showing a balance of 199€ in the first account.

I modified the amount of the account transfer on ivy wallet to observe some funny results, pfa some screenshots. The same error is also there if I change the amount to 67,55 (the total should be 100€ but it shows 99€)

To Reproduce

Add an account transfer to make the balance a multiple of 100

Expected behavior

The new balance should be exact

Screenshots

Smartphone

OnePlus Nord CE 2

Additional context

No response

[ivywallet]

Thank you @pravissw for raising Issue #2910! 🚀
What's next? Read our Contribution Guidelines 📚.

Tagging @ILIYANGERMANOV for review & approval 👀

[Vishwa-Raghavendra]

Hey @ILIYANGERMANOV
I would like to work on this but this would result in re-write of calculation methods
As we have a lot of deprecated methods / Act for it

Acceptable for re-work?

[ILIYANGERMANOV]

Hey @ILIYANGERMANOV
I would like to work on this but this would result in re-write of calculation methods
As we have a lot of deprecated methods / Act for it

Acceptable for re-work?

Hey @Vishwa-Raghavendra, ideally, we should rewrite them in :shared:domain as use-cases + unit tests and having the new domain model.

You can also fix the old ones if you wish but at one point they'll be thrown away

[Vishwa-Raghavendra]

Hey @ILIYANGERMANOV
I would like to work on this but this would result in re-write of calculation methods
As we have a lot of deprecated methods / Act for it
Acceptable for re-work?

Hey @Vishwa-Raghavendra, ideally, we should rewrite them in :shared:domain as use-cases + unit tests and having the new domain model.

You can also fix the old ones if you wish but at one point they'll be thrown away

Yes I was thinking the same,
re-write in shared:Domain as use cases with some tests

Can't fix the old ones now,
Too many modifications will result in unstable code

[ILIYANGERMANOV]

@Vishwa-Raghavendra that's perfect! The old ones are garbage, just make sure that the new are:

• type-safe
• do not throw exceptions, use Either
• make them type-safe
• simple
• main-safe (computations happen on a background thread)

Also check #2990

[Vishwa-Raghavendra]

Sure @ILIYANGERMANOV

[Vishwa-Raghavendra]

I'm on it

[ivywallet]

Thank you for your interest @Vishwa-Raghavendra! 🎉
Issue #2910 is assigned to you. You can work on it! ✅

If you don't want to work on it now, please un-assign yourself so other contributors can take it.

Also, make sure to read our Contribution Guidelines.

[ILIYANGERMANOV]

Hey @Vishwa-Raghavendra did you find anything about this one? I'm considering if we can release the current GitHub version to Beta