[IVY-2910] Fix Incorrect Balance Transfer

[Vishwa-Raghavendra]

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

• The PR is submitted to the main branch.
• I've read the Contribution Guidelines and my PR doesn't break the rules.
• I've read and understand the Developer Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

What's changed?

Describe with a few bullets what's new:

• a This fixes In correct Account Transfer that was happening (this isn't a rework)
• b
• c

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

• a
• b

In what cases your code won't work?

• a
• b

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

• Closes [BUG] Incorrect addition on account transfer #2910

Replace ISSUE_NUMBER with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description.

!Note: Do not link the PR number. Link the number/id of the GitHub Issue from issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

[ILIYANGERMANOV]

Do we need the same fix for transferExpense?

[Vishwa-Raghavendra]

Do we need the same fix for transferExpense?

Not Needed for TransfersExpense

[ILIYANGERMANOV]

Do we need the same fix for transferExpense?

Not Needed for TransfersExpense

@Vishwa-Raghavendra I don't get it. Why we need it only for income and not for expense? That feels incorrect

[Vishwa-Raghavendra]

Do we need the same fix for transferExpense?

Not Needed for TransfersExpense

@Vishwa-Raghavendra I don't get it. Why we need it only for income and not for expense? That feels incorrect

I meant we don't need any changes
the existing code is already checking for transferExpense

i.ie For a transfer from X to Y
is the fromX.accountId == accountId in consideration

Only for transferIncome it was broken so just fixed it up

[ILIYANGERMANOV]

Got it - thanks!