Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error initial amount in calculatorModal, adjust padding amount keyboard #3110

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix error initial amount in calculatorModal, adjust padding amount keyboard #3110

merged 1 commit into from
Apr 9, 2024

Conversation

isaacnguyen0809
Copy link
Contributor

@isaacnguyen0809 isaacnguyen0809 commented Apr 9, 2024 •
edited
Loading

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

What's changed?

  • Fix the initial amount from "0" to ""
  • Adjust padding betwwen number pad

Screen recording

Before After
https://github.com/Ivy-Apps/ivy-wallet/assets/57831153/da0f1b68-5c31-4511-9893-34acfeb66248 https://github.com/Ivy-Apps/ivy-wallet/assets/57831153/f5dac40b-e8e6-4c16-9bb1-a581be9cf26d

Risk Factors

No risk factors

ILIYANGERMANOV
ILIYANGERMANOV approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the new padding scale well on small devices?

@ILIYANGERMANOV ILIYANGERMANOV merged commit ce0da86 into Ivy-Apps:main Apr 9, 2024
8 checks passed
@isaacnguyen0809
Copy link
Contributor Author

Yes, I already tested on pixel 3 5.46 inch

@isaacnguyen0809
Copy link
Contributor Author

Oops, I just checked the video and this padding affects the calculatorModal UI a bit, I will adjust it along with store amount in double tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Keyboard Should be in less space [BUG] After update Calculator Starting from "0.00"
2 participants
@isaacnguyen0809 @ILIYANGERMANOV