Fix breaking changes caused by version upgrade and rollback version of androidx.biometric

[rafaeltonholo]

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

• The PR is submitted to the main branch.
• I've read the Contribution Guidelines and my PR doesn't break the rules.
• I've read and understand the Developer Guidelines.
• I confirm that I've run the code locally and everything works as expected.
• 🎬 I've attached a screen recoding of the changes.

What's changed?

• Fixes the breaking changes caused by version upgrade of:
  • AGP
  • Kover
  • Compose compiler
• Rollback the version of androidx.biometric:biometric from 1.4.0-alpha01 to 1.2.0-alpha05.
  • Reason: 1.4.0-alpha01 requires compileSdk version 35 and the app is using 34.
  • Suggestion: As the compileSkd upgrade usually requires more changes and closer attention, I would address that in a separate PR.

Risk Factors

What may go wrong if we merge your PR?

The present changes shouldn't affect the behaviour of the app.

Does this PR closes any GitHub Issues?

This present PR doesn't close any issue, but helps to address the following:

• Fix issues of Bump the ivy-wallet group with 44 updates #3240

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

[ILIYANGERMANOV]

Can you revert most of the changes and just edit libs.versions.toml? The other changes are breaking our automations and CI. Just picking the right library versions - upgrading the Android Gradle Plugin should be sufficient

[rafaeltonholo]

Can you revert most of the changes and just edit libs.versions.toml? The other changes are breaking our automations and CI. Just picking the right library versions - upgrading the Android Gradle Plugin should be sufficient

Hi @ILIYANGERMANOV, thanks for the input. I'm sorry, I must have misunderstood the requirements for this change.

I was under the understanding that the requirement was to make the #3240 pass the CI, and that is why I applied all those fixes.

Is the idea just to upgrade AGP and what is required to make it compile? If so, I would close this PR and open a new one. The reason is that I made this branch from dependabot/gradle/ivy-wallet-2ba47b89ce and it would be problematic to merge.

Regarding the CI issues, here are a few inputs on it:

• With the upgrade of paparazzi to 1.3.4, the screenshot tests started to fail. The solution would be to downgrade to 1.3.3 until they fix Rendering differences between platforms seems to have increased with 1.3.4 cashapp/paparazzi#1465
• With the upgrade of detekt to 1.23.6, it started failing with ParameterNaming, which can be quickly fixed by either renaming, suppressing or downgrading.

I looked into the other problems, but since this isn't what was requested, I can put it aside.

[ILIYANGERMANOV]

@rafaeltonholo got it. Let's:

• Downgrade Paparazzi
• Fix Detekt errors manually (that shouldn't be that hard, I guess) If the error is in the legacy code, you can directly @Suppress()

The idea was:

• do the minimal changes to make the dependabot PR green and work
• the fixes must not break the CI or existing automations

[ILIYANGERMANOV]

Most version upgrade fixes require:

• downgrade of troublesome libraries, you did the hard job by finding the culprits 👏 Kudos!
• fixing Detekt errors for new checks added with the newer versions
• fixing version incompatibilities

[ILIYANGERMANOV]

OMG! My bad, sorry! Actually your changes introduce the new bundled Compose in K2 👏

[ILIYANGERMANOV]

@rafaeltonholo great job! Any ideas why the Integration tests are failing? They run some of the code on a real Android device

[ILIYANGERMANOV]

At some point, we can get rid of Paparazzi in favor of https://developer.android.com/studio/preview/compose-screenshot-testing

[rafaeltonholo]

@rafaeltonholo great job! Any ideas why the Integration tests are failing? They run some of the code on a real Android device

I was looking into the lint issues before checking that. I still need to investigate why it is failing but looking at the error log, it might be related to the coroutine upgrade (I was looking to the wrong logs, lol). I still need to check.

[ILIYANGERMANOV]

Lint is easy to fix - some strings issues:

[rafaeltonholo]

Lint is easy to fix - some strings issues:

I was about to comment about that... It isn't too easy to fix, at least not for me as I don't speak Chinese haha
With the upgrade of the AGP to 8.5.0, the lint starts to fail because Android Lint detected that note_you_are_trying_to_change_the_account_associated_with_the_loan doesn't have any string parameter in the zh-rCN resource.

I have no idea where to put the parameter in this case and I didn't want to use a translator since it could provide a false positive fix.

Maybe someone in the telegram could provide the correct translated string?

[ILIYANGERMANOV]

@rafaeltonholo got it 😄 If you have ChatGPT or Gemini, you can ask it to put the String parameter at the correct place

[ILIYANGERMANOV]

Worst case: just hack %s string parameter at the end

[ILIYANGERMANOV]

@rafaeltonholo I found the string for you using ChatGPT:

<string name="note_you_are_trying_to_change_the_account_associated_with_the_loan">
    注意：您正在尝试将贷款 %s 关联的账户更改为不同货币的账户\n所有贷款记录将根据当天的汇率重新计算
</string>

Please fix new lines

[rafaeltonholo]

I finally found out why the integration test was failing. There is a change in the File.writeText(String, Charset) from Kotlin 1.9.23 to 2.0.0.

In Kotlin 1.9.23:

public fun File.writeText(text: String, charset: Charset = Charsets.UTF_8): Unit = writeBytes(text.toByteArray(charset))

In Kotlin 2.0.0:

public fun File.writeText(text: String, charset: Charset = Charsets.UTF_8): Unit =
    FileOutputStream(this).use { it.writeTextImpl(text, charset) }

Because of that, the integration test started to fail when trying to create the json data fail.

To fix the issue, that would be the required change:

    private fun createJsonDataFile(jsonString: String): File {
        val fileNamePrefix = "data"
        val fileNameSuffix = ".json"
        val outputDir = context.cacheDir

        val file = File.createTempFile(fileNamePrefix, fileNameSuffix, outputDir)
--        file.writeText(jsonString, Charsets.UTF_16)
++        FileOutputStream(file).use { it.write(jsonString.toByteArray(Charsets.UTF_16)) }

        return file
}

This is basically a replacement of the old implementation of public fun File.writeText(text: String, charset: Charset = Charsets.UTF_8): Unit

I'll test a bit more tomorrow before committing that change, but I would appreciate your inputs about that.

[ILIYANGERMANOV]

@rafaeltonholo great work! Can you fix the merge conflict and we can merge it?