fix: Fix issue #3244 #3246
Merged
fix: Fix issue #3244 #3246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@giuseppe2028 you need to update the Paparazzi screenshots https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md#paparazzi-tests |
temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/transaction/TransactionCard.kt
Show resolved
Hide resolved
temp/legacy-code/src/main/java/com/ivy/legacy/ui/component/transaction/TransactionCard.kt
Show resolved
Hide resolved
giuseppe2028
force-pushed
the
fix-issue-#3244
branch
2 times, most recently
from
01f962f
to
6f3b1e5
Compare
added 2 commits
June 21, 2024 21:36
|
I have tried all the possible solution, but the test does not run yet. |
@giuseppe2028 try increasing this to |
|
We recently updated Compose and there might be flaky Paparazzi tests. Also update your branch to be on top of the latest |
|
This #3243 should improve this suboptimal developer experience |
added 8 commits
June 22, 2024 22:39
# Conflicts: # screen/transactions/src/test/snapshots/images/com.ivy.transactions_TransactionsPaparazziTest_snapshot Transactions Screen[Dark].png # screen/transactions/src/test/snapshots/images/com.ivy.transactions_TransactionsPaparazziTest_snapshot Transactions Screen[Light].png # shared/ui/testing/src/main/java/com/ivy/ui/testing/PaparazziScreenshotTest.kt
giuseppe2028
commented
Jun 23, 2024
shared/ui/testing/src/main/java/com/ivy/ui/testing/PaparazziScreenshotTest.kt
Show resolved
Hide resolved
ILIYANGERMANOV
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) Checklist
Please check if your pull request fulfills the following requirements:
mainbranch.What's changed?
Describe with a few bullets what's new:
Risk Factors
What may go wrong if we merge your PR?
In what cases your code won't work?
0620.mov
Does this PR closes any GitHub Issues?
Check Ivy Wallet Issues.
Troubleshooting CI failures ❌
GitHub Actions failing? Read our CI Troubleshooting guide.