Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 3138 #3337

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Fix issue 3138 #3337

merged 5 commits into from
Jul 13, 2024

Conversation

suyash01
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

language_option.mp4

What's changed?

Describe with a few bullets what's new:

  • Adds language settings for Android 13 and above
Before After
before1 after1

Risk factors

What may go wrong if we merge your PR?

  • ...

In what cases won't your code work?

  • For Android 12 and below

Does this PR close any GitHub issues?

Troubleshooting CI failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great UX and a cool solution! Thank you for the nice PR description 💯
Before merging it you need address the screen architecture and work only inside the settings module. If you face any issues, do tag me and comment and I'll help :)

app/build.gradle.kts Outdated Show resolved Hide resolved
app/src/main/java/com/ivy/wallet/RootActivity.kt Outdated Show resolved Hide resolved
shared/ui/core/src/main/java/com/ivy/ui/ViewModelEvent.kt Outdated Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Jul 12, 2024
@ILIYANGERMANOV
Copy link
Collaborator

@suyash01 check this doc
https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/guidelines/Screen-Architecture.md

Also feel free to suggest how to make it better

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@ILIYANGERMANOV ILIYANGERMANOV merged commit 84fff68 into Ivy-Apps:main Jul 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a language dropdown in Settings
2 participants