Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fx2 / delay lp aliasing / Diffuser click on change #41

Closed
wants to merge 14 commits into from
Closed

Fx2 / delay lp aliasing / Diffuser click on change #41

wants to merge 14 commits into from

Conversation

pvig
Copy link
Contributor

@pvig pvig commented May 22, 2023

No description provided.

Ixox
Ixox reviewed May 23, 2023
View reviewed changes
firmware/Src/synth/Timbre.h Outdated Show resolved Hide resolved
firmware/Src/synth/Timbre.cpp Outdated Show resolved Hide resolved
pvig
pvig commented May 24, 2023
View reviewed changes
Copy link
Contributor Author

@pvig pvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variables cleaned

Ixox
Ixox reviewed May 24, 2023
View reviewed changes
firmware/Src/synth/Timbre.cpp Outdated Show resolved Hide resolved
Ixox
Ixox reviewed May 24, 2023
View reviewed changes
firmware/Src/synth/Timbre.cpp Outdated Show resolved Hide resolved
pvig
pvig commented May 25, 2023
View reviewed changes
Copy link
Contributor Author

@pvig pvig left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !
c'est nettoyé

pvig
pvig commented May 25, 2023
View reviewed changes
Copy link
Contributor Author

@pvig pvig left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diffuser 5 bug fix
il était la depuis un moment celui la..

pvig
pvig commented May 27, 2023
View reviewed changes
Copy link
Contributor Author

@pvig pvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit of tweaking for the Diff fx

@pvig
Copy link
Contributor Author

pvig commented May 27, 2023

Seems ok ?

@Ixox
Copy link
Owner

Ixox commented May 27, 2023 via email •
edited

@Ixox
Copy link
Owner

Ixox commented Jul 15, 2023

Merged

@Ixox Ixox closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ixox Ixox Ixox left review comments

@patvig patvig patvig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvig @Ixox @patvig