Update fork #7
Merged
Update fork #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add sorted in the read_all. file input was nonsensical. Probably happened due to transfer of files from Windows to Kubuntu.
OK. Thank you.
Correct the nports according to proposal from @cloidnerux in issue #366
Allez, we're done for now.
Fix issue 369
Correct nrows according to the proposal
fixed error: plotted different mode gain instead of common mode gain
This fixes `` [...]/python3.8/site-packages/skrf/network.py:3039: SyntaxWarning: "is not" with a literal. Did you mean "!="? if Pa.shape[0] is not 0: [...]/python3.8/site-packages/skrf/network.py:3385: SyntaxWarning: "is" with a literal. Did you mean "=="? if common_freq[0].size is 0: ``
Fix Python 3.8 SyntaxWarnings
…it and compared to ANSYS HFSS and Designer results.
Mention the 'traveling' option in the s_def option in the API
test again a simple transmission line
remove not used imports
Voltages and currents calculation in Circuit
Don't shadow skrf's io module with the system io module.
New Release
While the mathematical result is different due to the different iFFT/FFT normalization, final result is the same as the kernel is normalized.
change ifft to fft in gate frequency domain calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update