Skip to content

Commit

Permalink
Update benchmark setup in GitHub workflow and Makefile
Browse files Browse the repository at this point in the history
The GitHub workflow and Makefile have been updated for a better benchmark setup. A separate step for multi-threaded benchmarking has been added and the method of generating random integers in the CSV file has been altered. The adjustments provide a clearer understanding of the process and better use of resources.
  • Loading branch information
SmetDenis committed Apr 11, 2024
1 parent 4ebcc7c commit 12d5f13
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,5 @@ RUN php ./docker/random-csv.php \
# Quick test
RUN time ./csv-blueprint -V

#ENTRYPOINT ["/app/docker/entrypoint.sh"]
ENTRYPOINT ["/app/csv-blueprint"]
ENTRYPOINT ["/app/docker/entrypoint.sh"]
#ENTRYPOINT ["/app/csv-blueprint"]
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1466,7 +1466,7 @@ Options:
--debug Intended solely for debugging and advanced profiling purposes.
Activating this option provides detailed process insights,
useful for troubleshooting and performance analysis.
-p, --parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel.
--parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel.
You can specify the number of threads.
If you do not specify a value, the number of threads will be equal to the number of CPU cores.
By default, the process is launched in a single-threaded mode. [default: "1"]
Expand Down Expand Up @@ -1526,7 +1526,7 @@ Options:
--debug Intended solely for debugging and advanced profiling purposes.
Activating this option provides detailed process insights,
useful for troubleshooting and performance analysis.
-p, --parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel.
--parallel[=PARALLEL] EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel.
You can specify the number of threads.
If you do not specify a value, the number of threads will be equal to the number of CPU cores.
By default, the process is launched in a single-threaded mode. [default: "1"]
Expand Down
4 changes: 2 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ inputs:
default: 'options: --ansi'

runs:
using: docker
image: Dockerfile
using: 'docker'
image: 'docker://jbzoo/csv-blueprint'
args:
- validate:csv
- '--csv'
Expand Down
2 changes: 1 addition & 1 deletion src/Commands/AbstractValidate.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ protected function configure(): void
)
->addOption(
'parallel',
'p',
null,
InputOption::VALUE_OPTIONAL,
\implode("\n", [
'EXPERIMENTAL! Launches the process in parallel mode (if possible). Works only with ext-parallel.',
Expand Down

0 comments on commit 12d5f13

Please sign in to comment.