Improve error reporting and streamline codebase

Updated the error reporting in 'ValidateCsv' file to include the word 'Error' in red for clearer visibility. Also simplified the depth condition in the 'Utils' file and made the 'location' element more concise in 'ValidatorTest'. This makes the code cleaner, more readable and enhances the visibility of errors.
JBZoo · Mar 12, 2024 · 78ec043 · 78ec043
1 parent ac6e5c5
commit 78ec043
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/src/Commands/ValidateCsv.php b/src/Commands/ValidateCsv.php
@@ -91,7 +91,7 @@ protected function executeAction(): int
                 $errorCounter += $errorSuite->count();
 
                 if ($this->isTextMode()) {
-                    $this->_(Utils::cutPath($csvFilename->getPathname()), OutLvl::ERROR);
+                    $this->_('<red>Error</red>: ' . Utils::cutPath($csvFilename->getPathname()), OutLvl::E);
                 }
                 $output = $errorSuite->render($this->getOptString('report'));
                 if ($output !== null) {

diff --git a/src/Utils.php b/src/Utils.php
@@ -68,7 +68,7 @@ public static function findFiles(array $paths): array
             if (\strpos($path, '*') !== false) {
                 $finder = (new Finder())
                     ->in(\dirname($path))
-                    ->depth('< ' . self::MAX_DIRECTORY_DEPTH)
+                    // ->depth(self::MAX_DIRECTORY_DEPTH)
                     ->ignoreVCSIgnored(true)
                     ->ignoreDotFiles(true)
                     ->followLinks()

diff --git a/tests/Blueprint/ValidatorTest.php b/tests/Blueprint/ValidatorTest.php
@@ -515,22 +515,14 @@ public function testRenderGitlab(): void
                 [
                     'description' => "min at column 0:seq\n\"min\" at line 2, " .
                         'column "0:seq". Value "1" is less than "3".',
-                    // 'fingerprint' => '...',
                     'severity' => 'major',
-                    'location' => [
-                        'path'  => $path,
-                        'lines' => ['begin' => 2],
-                    ],
+                    'location' => ['path' => $path, 'lines' => ['begin' => 2]],
                 ],
                 [
                     'description' => "min at column 0:seq\n\"min\" at line 3, " .
                         'column "0:seq". Value "2" is less than "3".',
-                    // 'fingerprint' => '..',
                     'severity' => 'major',
-                    'location' => [
-                        'path'  => $path,
-                        'lines' => ['begin' => 3],
-                    ],
+                    'location' => ['path' => $path, 'lines' => ['begin' => 3]],
                 ],
             ],
             $cleanJson,